From: Al Viro <viro@ZenIV.linux.org.uk>
To: zhong jiang <zhongjiang@huawei.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote
Date: Thu, 2 Aug 2018 04:05:22 +0100 [thread overview]
Message-ID: <20180802030522.GX30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1533175474-17785-1-git-send-email-zhongjiang@huawei.com>
On Thu, Aug 02, 2018 at 10:04:34AM +0800, zhong jiang wrote:
> It is unncessary to use double test for a expression. so just
> remove one of them.
... except when something in that expression might have side effects,
that is.
prev parent reply other threads:[~2018-08-02 3:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 2:04 [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote zhong jiang
2018-08-02 2:51 ` zhong jiang
2018-08-02 3:05 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802030522.GX30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox