From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 11/18] staging:rtl8192u: Remove member reserved - Style
Date: Fri, 3 Aug 2018 01:02:04 +0100 [thread overview]
Message-ID: <20180803000211.10589-12-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180803000211.10589-1-johnfwhitmore@gmail.com>
The structure dynamic_rx_path_sel contains a u8 member variable called
reserved. This member variable is never actually used in the code.
The naming suggests that the sizeof the structure is significant but
the only use of the structure is a local static in r8192U_dm.c:
static struct dynamic_rx_path_sel DM_RxPathSelTable;
There is no apparent significance to the sizeof the declared structure
DM_RxPathSelTable. As a result the reserved member variable has been
removed from the structure.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r8192U_dm.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
index 74742cb27a2c..66dfcbbf6e43 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u/r8192U_dm.h
@@ -133,7 +133,6 @@ struct dynamic_rx_path_sel {
u8 cck_rx_path;
u8 disabled_rf;
- u8 reserved;
u8 rf_rssi[4];
u8 rf_enable_rssi_th[4];
--
2.18.0
next prev parent reply other threads:[~2018-08-03 0:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 0:01 [PATCH 00/18] staging:rtl8192u: Clean up ofr8192U_dm.h John Whitmore
2018-08-03 0:01 ` [PATCH 01/18] staging:rtl8192u: Remove debug member from structures - Style John Whitmore
2018-08-03 0:01 ` [PATCH 02/18] staging:rtl8192u: Remove member variable rx_gain_range_max " John Whitmore
2018-08-03 0:01 ` [PATCH 03/18] staging:rtl8192u: Remove member initialgain_lowerbound_state " John Whitmore
2018-08-03 0:01 ` [PATCH 04/18] staging:rtl8192u: Rename enum constants " John Whitmore
2018-08-03 0:01 ` [PATCH 05/18] staging:rtl8192u: Remove unused extern DM_RxPathSelTable " John Whitmore
2018-08-03 0:01 ` [PATCH 06/18] staging:rtl8192u: Remove member variable Enable " John Whitmore
2018-08-03 0:02 ` [PATCH 07/18] staging:rtl8192u: Rename cck_Rx_path " John Whitmore
2018-08-03 0:02 ` [PATCH 08/18] staging:rtl8192u: Remove SS_TH_low " John Whitmore
2018-08-03 0:02 ` [PATCH 09/18] staging:rtl8192u: Remove member diff_TH " John Whitmore
2018-08-03 0:02 ` [PATCH 10/18] staging:rtl8192u: Rename member disabledRF " John Whitmore
2018-08-03 0:02 ` John Whitmore [this message]
2018-08-03 0:02 ` [PATCH 12/18] staging:rtl8192u: Refactor DCMD_TXCMD_T structure " John Whitmore
2018-08-03 0:02 ` [PATCH 13/18] staging:rtl8192u: Rename DM_DIG_MIN_Netcore " John Whitmore
2018-08-03 0:02 ` [PATCH 14/18] staging:rtl8192u: Rename RateAdaptiveTH_High " John Whitmore
2018-08-03 0:02 ` [PATCH 15/18] staging:rtl8192u: Rename constants RateAdaptiveTH_Low_* " John Whitmore
2018-08-03 0:02 ` [PATCH 16/18] staging:rtl8192u: Rename constants " John Whitmore
2018-08-03 0:02 ` [PATCH 17/18] staging:rtl8192u: Rename Register Constants " John Whitmore
2018-08-03 0:02 ` [PATCH 18/18] staging:rtl8192u: Clean up of spacing " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803000211.10589-12-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox