From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 14/18] staging:rtl8192u: Rename RateAdaptiveTH_High - Style
Date: Fri, 3 Aug 2018 01:02:07 +0100 [thread overview]
Message-ID: <20180803000211.10589-15-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180803000211.10589-1-johnfwhitmore@gmail.com>
The constant RateAdaptiveTH_High causes a checkpatch issue with respect
to CamelCase naming. As a result the constant has been renamed to
RATE_ADAPTIVE_TH_HIGH.
This is purely a coding style change which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
drivers/staging/rtl8192u/r8192U_dm.c | 4 ++--
drivers/staging/rtl8192u/r8192U_dm.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 28592a8d6dd0..d4a063afca55 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -3079,9 +3079,9 @@ static bool HalRxCheckStuck819xUsb(struct net_device *dev)
* or maybe it will continuous silent reset every 2 seconds.
*/
rx_chk_cnt++;
- if (priv->undecorated_smoothed_pwdb >= (RateAdaptiveTH_High + 5)) {
+ if (priv->undecorated_smoothed_pwdb >= (RATE_ADAPTIVE_TH_HIGH + 5)) {
rx_chk_cnt = 0; /* high rssi, check rx stuck right now. */
- } else if (priv->undecorated_smoothed_pwdb < (RateAdaptiveTH_High + 5) &&
+ } else if (priv->undecorated_smoothed_pwdb < (RATE_ADAPTIVE_TH_HIGH + 5) &&
((priv->CurrentChannelBW != HT_CHANNEL_WIDTH_20 && priv->undecorated_smoothed_pwdb >= RateAdaptiveTH_Low_40M) ||
(priv->CurrentChannelBW == HT_CHANNEL_WIDTH_20 && priv->undecorated_smoothed_pwdb >= RateAdaptiveTH_Low_20M))) {
if (rx_chk_cnt < 2)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
index 3043b84e9237..b9b751fb96c3 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.c
+++ b/drivers/staging/rtl8192u/r8192U_dm.c
@@ -243,11 +243,11 @@ void init_rate_adaptive(struct net_device *dev)
prate_adaptive pra = (prate_adaptive)&priv->rate_adaptive;
pra->ratr_state = DM_RATR_STA_MAX;
- pra->high2low_rssi_thresh_for_ra = RateAdaptiveTH_High;
+ pra->high2low_rssi_thresh_for_ra = RATE_ADAPTIVE_TH_HIGH;
pra->low2high_rssi_thresh_for_ra20M = RateAdaptiveTH_Low_20M+5;
pra->low2high_rssi_thresh_for_ra40M = RateAdaptiveTH_Low_40M+5;
- pra->high_rssi_thresh_for_ra = RateAdaptiveTH_High+5;
+ pra->high_rssi_thresh_for_ra = RATE_ADAPTIVE_TH_HIGH + 5;
pra->low_rssi_thresh_for_ra20M = RateAdaptiveTH_Low_20M;
pra->low_rssi_thresh_for_ra40M = RateAdaptiveTH_Low_40M;
diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
index 655b1afd9294..07e80e064f76 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u/r8192U_dm.h
@@ -40,7 +40,7 @@
#define RX_PATH_SELECTION_SS_TH_LOW 30
#define RX_PATH_SELECTION_DIFF_TH 18
-#define RateAdaptiveTH_High 50
+#define RATE_ADAPTIVE_TH_HIGH 50
#define RateAdaptiveTH_Low_20M 30
#define RateAdaptiveTH_Low_40M 10
#define VeryLowRSSI 15
--
2.18.0
next prev parent reply other threads:[~2018-08-03 0:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 0:01 [PATCH 00/18] staging:rtl8192u: Clean up ofr8192U_dm.h John Whitmore
2018-08-03 0:01 ` [PATCH 01/18] staging:rtl8192u: Remove debug member from structures - Style John Whitmore
2018-08-03 0:01 ` [PATCH 02/18] staging:rtl8192u: Remove member variable rx_gain_range_max " John Whitmore
2018-08-03 0:01 ` [PATCH 03/18] staging:rtl8192u: Remove member initialgain_lowerbound_state " John Whitmore
2018-08-03 0:01 ` [PATCH 04/18] staging:rtl8192u: Rename enum constants " John Whitmore
2018-08-03 0:01 ` [PATCH 05/18] staging:rtl8192u: Remove unused extern DM_RxPathSelTable " John Whitmore
2018-08-03 0:01 ` [PATCH 06/18] staging:rtl8192u: Remove member variable Enable " John Whitmore
2018-08-03 0:02 ` [PATCH 07/18] staging:rtl8192u: Rename cck_Rx_path " John Whitmore
2018-08-03 0:02 ` [PATCH 08/18] staging:rtl8192u: Remove SS_TH_low " John Whitmore
2018-08-03 0:02 ` [PATCH 09/18] staging:rtl8192u: Remove member diff_TH " John Whitmore
2018-08-03 0:02 ` [PATCH 10/18] staging:rtl8192u: Rename member disabledRF " John Whitmore
2018-08-03 0:02 ` [PATCH 11/18] staging:rtl8192u: Remove member reserved " John Whitmore
2018-08-03 0:02 ` [PATCH 12/18] staging:rtl8192u: Refactor DCMD_TXCMD_T structure " John Whitmore
2018-08-03 0:02 ` [PATCH 13/18] staging:rtl8192u: Rename DM_DIG_MIN_Netcore " John Whitmore
2018-08-03 0:02 ` John Whitmore [this message]
2018-08-03 0:02 ` [PATCH 15/18] staging:rtl8192u: Rename constants RateAdaptiveTH_Low_* " John Whitmore
2018-08-03 0:02 ` [PATCH 16/18] staging:rtl8192u: Rename constants " John Whitmore
2018-08-03 0:02 ` [PATCH 17/18] staging:rtl8192u: Rename Register Constants " John Whitmore
2018-08-03 0:02 ` [PATCH 18/18] staging:rtl8192u: Clean up of spacing " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803000211.10589-15-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox