From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 16/18] staging:rtl8192u: Rename constants - Style
Date: Fri, 3 Aug 2018 01:02:09 +0100 [thread overview]
Message-ID: <20180803000211.10589-17-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180803000211.10589-1-johnfwhitmore@gmail.com>
The constants 'VeryLowRSSI' and 'CTSToSelfTHVal' generate warnings from
checkpatch due to the use of CamelCase naming. The two constants have
been renamed to 'VERY_LOW_RSSI' and 'CTS_TO_SELF_TH_VAL' respectively.
These are coding style changes which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
drivers/staging/rtl8192u/r8192U_dm.c | 2 +-
drivers/staging/rtl8192u/r8192U_dm.h | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 6129ac55656f..e218b5c20642 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -3090,7 +3090,7 @@ static bool HalRxCheckStuck819xUsb(struct net_device *dev)
rx_chk_cnt = 0;
} else if (((priv->CurrentChannelBW != HT_CHANNEL_WIDTH_20 && priv->undecorated_smoothed_pwdb < RATE_ADAPTIVE_TH_LOW_40M) ||
(priv->CurrentChannelBW == HT_CHANNEL_WIDTH_20 && priv->undecorated_smoothed_pwdb < RATE_ADAPTIVE_TH_LOW_20M)) &&
- priv->undecorated_smoothed_pwdb >= VeryLowRSSI) {
+ priv->undecorated_smoothed_pwdb >= VERY_LOW_RSSI) {
if (rx_chk_cnt < 4)
return bStuck;
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
index 21107a00776f..0e4f55c6493f 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.c
+++ b/drivers/staging/rtl8192u/r8192U_dm.c
@@ -2268,7 +2268,7 @@ static void dm_init_ctstoself(struct net_device *dev)
struct r8192_priv *priv = ieee80211_priv(dev);
priv->ieee80211->bCTSToSelfEnable = true;
- priv->ieee80211->CTSToSelfTH = CTSToSelfTHVal;
+ priv->ieee80211->CTSToSelfTH = CTS_TO_SELF_TH_VAL;
}
static void dm_ctstoself(struct net_device *dev)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
index a1378488423b..30241d91e44a 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u/r8192U_dm.h
@@ -43,8 +43,8 @@
#define RATE_ADAPTIVE_TH_HIGH 50
#define RATE_ADAPTIVE_TH_LOW_20M 30
#define RATE_ADAPTIVE_TH_LOW_40M 10
-#define VeryLowRSSI 15
-#define CTSToSelfTHVal 30
+#define VERY_LOW_RSSI 15
+#define CTS_TO_SELF_TH_VAL 30
/* defined by vivi, for tx power track */
#define E_FOR_TX_POWER_TRACK 300
--
2.18.0
next prev parent reply other threads:[~2018-08-03 0:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 0:01 [PATCH 00/18] staging:rtl8192u: Clean up ofr8192U_dm.h John Whitmore
2018-08-03 0:01 ` [PATCH 01/18] staging:rtl8192u: Remove debug member from structures - Style John Whitmore
2018-08-03 0:01 ` [PATCH 02/18] staging:rtl8192u: Remove member variable rx_gain_range_max " John Whitmore
2018-08-03 0:01 ` [PATCH 03/18] staging:rtl8192u: Remove member initialgain_lowerbound_state " John Whitmore
2018-08-03 0:01 ` [PATCH 04/18] staging:rtl8192u: Rename enum constants " John Whitmore
2018-08-03 0:01 ` [PATCH 05/18] staging:rtl8192u: Remove unused extern DM_RxPathSelTable " John Whitmore
2018-08-03 0:01 ` [PATCH 06/18] staging:rtl8192u: Remove member variable Enable " John Whitmore
2018-08-03 0:02 ` [PATCH 07/18] staging:rtl8192u: Rename cck_Rx_path " John Whitmore
2018-08-03 0:02 ` [PATCH 08/18] staging:rtl8192u: Remove SS_TH_low " John Whitmore
2018-08-03 0:02 ` [PATCH 09/18] staging:rtl8192u: Remove member diff_TH " John Whitmore
2018-08-03 0:02 ` [PATCH 10/18] staging:rtl8192u: Rename member disabledRF " John Whitmore
2018-08-03 0:02 ` [PATCH 11/18] staging:rtl8192u: Remove member reserved " John Whitmore
2018-08-03 0:02 ` [PATCH 12/18] staging:rtl8192u: Refactor DCMD_TXCMD_T structure " John Whitmore
2018-08-03 0:02 ` [PATCH 13/18] staging:rtl8192u: Rename DM_DIG_MIN_Netcore " John Whitmore
2018-08-03 0:02 ` [PATCH 14/18] staging:rtl8192u: Rename RateAdaptiveTH_High " John Whitmore
2018-08-03 0:02 ` [PATCH 15/18] staging:rtl8192u: Rename constants RateAdaptiveTH_Low_* " John Whitmore
2018-08-03 0:02 ` John Whitmore [this message]
2018-08-03 0:02 ` [PATCH 17/18] staging:rtl8192u: Rename Register Constants " John Whitmore
2018-08-03 0:02 ` [PATCH 18/18] staging:rtl8192u: Clean up of spacing " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803000211.10589-17-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox