From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Tino Lehnig <tino.lehnig@contabo.de>,
stable@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature
Date: Fri, 3 Aug 2018 14:23:06 +0900 [thread overview]
Message-ID: <20180803052306.GC502@jagdpanzerIV> (raw)
In-Reply-To: <20180803045121.GC86818@rodete-desktop-imager.corp.google.com>
On (08/03/18 13:51), Minchan Kim wrote:
>
> AFAIK, onging writeback page couldn't freed so it was not writeabck problem.
>
> What I'm tryig to fix is read part.
> If we use swapcache, it shouldn't be a problem either because swapcache
> has a reference count and we should wait PG_lock release before the freeing
> from the swapcache so there is no race condition.
Hmm, any chance a WB device can be async on its own? We add a page
to a new bio and submit it to another async device driver. Then we
return back to the upper layer (swap), which can free a page before
the device picks up a request. Can this happen?
[..]
> However, I decided, at this moment, going this simple way for
> stable-material to solve #0 and #1 problems at the same time.
Agreed. Thanks.
-ss
next prev parent reply other threads:[~2018-08-03 5:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 5:11 [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature Minchan Kim
2018-08-02 21:13 ` Andrew Morton
2018-08-03 2:39 ` Sergey Senozhatsky
2018-08-03 2:52 ` Sergey Senozhatsky
2018-08-03 3:00 ` Minchan Kim
2018-08-03 4:13 ` Sergey Senozhatsky
2018-08-03 4:51 ` Minchan Kim
2018-08-03 5:23 ` Sergey Senozhatsky [this message]
2018-08-03 5:45 ` Sergey Senozhatsky
2018-08-03 2:51 ` Minchan Kim
2018-08-03 23:28 ` Andrew Morton
2018-08-05 23:15 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803052306.GC502@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tino.lehnig@contabo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox