public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Sinan Kaya <okaya@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Don Zickus <dzickus@redhat.com>, Ingo Molnar <mingo@kernel.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Colin Ian King <colin.king@canonical.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH v2] watchdog: Reduce message verbosity
Date: Thu,  2 Aug 2018 23:09:41 -0700	[thread overview]
Message-ID: <20180803060943.2643-1-okaya@kernel.org> (raw)

Code is emitting the following error message during boot on systems
without PMU hardware support while probing NMI capability.

NMI watchdog: Perf event create on CPU 0 failed with -2

This error is coming from this path:

lockup_detector_init
  watchdog_nmi_probe
    hardlockup_detector_perf_init
      hardlockup_detector_event_create
        perf_event_create_kernel_counter
          perf_event_alloc
            perf_init_event (9539)
              pmu = ERR_PTR(-ENOENT) due to lack of PMUs in the system

followed by the warning that NMI watchdog is disabled as follows.

NMI watchdog: Perf NMI watchdog permanently disabled

While NMI disabled information is usefel for ordinary users, seeing
a PERF event create failed with error code -2 is too verbose.

Reducing the message severity to debug so that if somebody is really
wants to debug this, they can find out the error source by increasing
the kernel loglevel during boot.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=599368
---
 kernel/watchdog_hld.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/watchdog_hld.c b/kernel/watchdog_hld.c
index e449a23e9d59..1f7020d65d0a 100644
--- a/kernel/watchdog_hld.c
+++ b/kernel/watchdog_hld.c
@@ -175,8 +175,8 @@ static int hardlockup_detector_event_create(void)
 	evt = perf_event_create_kernel_counter(wd_attr, cpu, NULL,
 					       watchdog_overflow_callback, NULL);
 	if (IS_ERR(evt)) {
-		pr_info("Perf event create on CPU %d failed with %ld\n", cpu,
-			PTR_ERR(evt));
+		pr_debug("Perf event create on CPU %d failed with %ld\n", cpu,
+			 PTR_ERR(evt));
 		return PTR_ERR(evt);
 	}
 	this_cpu_write(watchdog_ev, evt);
-- 
2.17.1


             reply	other threads:[~2018-08-03  6:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03  6:09 Sinan Kaya [this message]
2018-08-03 10:24 ` [tip:sched/core] watchdog: Reduce message verbosity tip-bot for Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180803060943.2643-1-okaya@kernel.org \
    --to=okaya@kernel.org \
    --cc=colin.king@canonical.com \
    --cc=dzickus@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox