From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB45C28CF6 for ; Fri, 3 Aug 2018 10:09:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 402AC21717 for ; Fri, 3 Aug 2018 10:09:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 402AC21717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732493AbeHCMFS (ORCPT ); Fri, 3 Aug 2018 08:05:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53372 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728450AbeHCMFS (ORCPT ); Fri, 3 Aug 2018 08:05:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 29F184012981; Fri, 3 Aug 2018 10:09:42 +0000 (UTC) Received: from localhost (unknown [10.40.205.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 678152142F20; Fri, 3 Aug 2018 10:09:41 +0000 (UTC) Date: Fri, 3 Aug 2018 12:09:40 +0200 From: Stanislaw Gruszka To: Kalle Valo Cc: Wireless , Stephen Rothwell , Linux-Next Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] mt76x0: build driver only as module Message-ID: <20180803100939.GE10284@redhat.com> References: <20180803091401.GB10284@redhat.com> <87zhy36c4n.fsf@kamboji.qca.qualcomm.com> <20180803092822.GD10284@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180803092822.GD10284@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 03 Aug 2018 10:09:42 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 03 Aug 2018 10:09:42 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'sgruszka@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 03, 2018 at 11:28:22AM +0200, Stanislaw Gruszka wrote: > > But this feels like an ugly hack to me. Isn't there a better way to fix > > this? (I don't have time to investigate the error in detail right now.) > > Yes, rename symbols names. And I will do this, just wanted to provide > quick fix for the problem. > > Moreover seems the same thing should be done for mt7601u to avoid build > errors and perhaps with mt76 :-( > > So I'm going to rename functions. I have the patches, I'm building kernel with allyesconfig now, it will take a while ... Stanislaw