From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 2/7] staging:rtl8192u: Rename types in QOS_TCLAS union - Style
Date: Sat, 4 Aug 2018 10:18:54 +0100 [thread overview]
Message-ID: <20180804091859.6729-3-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180804091859.6729-1-johnfwhitmore@gmail.com>
Whilst none of the structures inside the qos_tclas union are used, their
names conflict with the coding standard being named in uppercase.
The names of all five have been changed to lowercase.
This is a style change, and since none of the structures are referenced,
these changes should have no impact on runtime code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_TS.h | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
index 823ba363e0ab..c352ba0bcd8f 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
@@ -16,22 +16,22 @@ enum tr_select {
union qos_tclas {
- struct _TYPE_GENERAL {
+ struct type_general {
u8 Priority;
u8 ClassifierType;
u8 Mask;
- } TYPE_GENERAL;
+ } type_general;
- struct _TYPE0_ETH {
+ struct type0_eth {
u8 Priority;
u8 ClassifierType;
u8 Mask;
u8 SrcAddr[6];
u8 DstAddr[6];
u16 Type;
- } TYPE0_ETH;
+ } type0_eth;
- struct _TYPE1_IPV4 {
+ struct type1_ipv4 {
u8 Priority;
u8 ClassifierType;
u8 Mask;
@@ -43,9 +43,9 @@ union qos_tclas {
u8 DSCP;
u8 Protocol;
u8 Reserved;
- } TYPE1_IPV4;
+ } type1_ipv4;
- struct _TYPE1_IPV6 {
+ struct type1_ipv6 {
u8 Priority;
u8 ClassifierType;
u8 Mask;
@@ -55,14 +55,14 @@ union qos_tclas {
u16 SrcPort;
u16 DstPort;
u8 FlowLabel[3];
- } TYPE1_IPV6;
+ } type1_ipv6;
- struct _TYPE2_8021Q {
+ struct type2_8021q {
u8 Priority;
u8 ClassifierType;
u8 Mask;
u16 TagType;
- } TYPE2_8021Q;
+ } type2_8021q;
};
struct ts_common_info {
--
2.18.0
next prev parent reply other threads:[~2018-08-04 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 9:18 [PATCH 0/7] staging:rtl8192u: Coding style changes John Whitmore
2018-08-04 9:18 ` [PATCH 1/7] staging:rtl8192u: Remove typedef and rename QOS_TCLAS - Style John Whitmore
2018-08-04 9:18 ` John Whitmore [this message]
2018-08-04 9:18 ` [PATCH 3/7] staging:rtl8192u: Rename multiple variables " John Whitmore
2018-08-04 9:18 ` [PATCH 4/7] staging:rtl8192u: Remove blank line " John Whitmore
2018-08-04 9:18 ` [PATCH 5/7] staging:rtl8192u: Remove comments " John Whitmore
2018-08-04 9:18 ` [PATCH 6/7] staging:rtl8192u: Remove unused member variable " John Whitmore
2018-08-05 14:22 ` Greg KH
2018-08-04 9:18 ` [PATCH 7/7] staging:rtl8192u: Replace magic number with defined constant " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180804091859.6729-3-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox