public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Keerthy <j-keerthy@ti.com>
Cc: daniel.lezcano@linaro.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	baolin.wang@linaro.org, d-gerlach@ti.com,
	grygorii.strashko@ti.com, t-kristo@ti.com
Subject: Re: [PATCH] clocksource: ti-32k: Remove CLOCK_SOURCE_SUSPEND_NONSTOP flag
Date: Mon, 6 Aug 2018 01:16:56 -0700	[thread overview]
Message-ID: <20180806081656.GN99251@atomide.com> (raw)
In-Reply-To: <1533191716-20476-1-git-send-email-j-keerthy@ti.com>

Keerthy,

* Keerthy <j-keerthy@ti.com> [180802 06:39]:
> With the introduction of below commit:
> 
> commit 39232ed5a1793f67b11430c43ed8a9ed6e96c6eb
> 
> time: Introduce one suspend clocksource to compensate the suspend time
> 
> The suspend/resume fails on AM437x platforms as the source is not
> a non-stop while trying to compensate time using this.
>
> Hence remove the CLOCK_SOURCE_SUSPEND_NONSTOP flag.

The 32k timer only stops on am4, on omap3 to omap5 and dra7 it's always
on. So the NONSTOP flag should be removed only for am4.

Care to do an incremental patch clearing NONSTOP based on compatible
property?

Regards,

Tony

> Suggested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/clocksource/timer-ti-32k.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
> index 880a861..7368e8e 100644
> --- a/drivers/clocksource/timer-ti-32k.c
> +++ b/drivers/clocksource/timer-ti-32k.c
> @@ -78,8 +78,7 @@ static u64 notrace ti_32k_read_cycles(struct clocksource *cs)
>  		.rating		= 250,
>  		.read		= ti_32k_read_cycles,
>  		.mask		= CLOCKSOURCE_MASK(32),
> -		.flags		= CLOCK_SOURCE_IS_CONTINUOUS |
> -				CLOCK_SOURCE_SUSPEND_NONSTOP,
> +		.flags		= CLOCK_SOURCE_IS_CONTINUOUS, 
>  	},
>  };
>  
> -- 
> 1.9.1
> 

      parent reply	other threads:[~2018-08-06  8:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02  6:35 [PATCH] clocksource: ti-32k: Remove CLOCK_SOURCE_SUSPEND_NONSTOP flag Keerthy
2018-08-02 11:39 ` [tip:timers/core] " tip-bot for Keerthy
2018-08-06  8:16 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180806081656.GN99251@atomide.com \
    --to=tony@atomide.com \
    --cc=baolin.wang@linaro.org \
    --cc=d-gerlach@ti.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=grygorii.strashko@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox