Re: [PATCH 0/4][RFC v2] Introduce the in-kernel hibernation encryption

Yu Chen
2018-07-18T23:53:04Z

Hi,
On Wed, Jul 18, 2018 at 10:22:35PM +0200, Pavel Machek wrote:
> On Thu 2018-07-19 00:38:06, Chen Yu wrote:
> > As security becomes more and more important, we add the in-kernel
> > encryption support for hibernation.
>
> Sorry, this does not really explain what security benefit it is
> supposed have to against what attack scenarios.
>
> Which unfortunately means it can not reviewed.
>
> Note that uswsusp already provides encryption. If this is supposed to
> have advantages over it, please say so.
>
The advantages are described in detail in
[PATCH 1/4]'s log, please refer to that.
Thanks,
Yu
> Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html