From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: "Lee, Chun-Yi" <jlee@suse.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Joe Perches <joe@perches.com>,
David Laight <David.Laight@aculab.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: [PATCH v2] platform/x86: acer-wmi: refactor function has_cap
Date: Mon, 6 Aug 2018 15:38:32 -0500 [thread overview]
Message-ID: <20180806203832.GA11751@embeddedor.com> (raw)
Refactor function has_cap in order to avoid returning integer
values, when instead it should return booleans.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
Changes in v2:
Remove parentheses and unnecessary code. Thank you all for
the feedback!
drivers/platform/x86/acer-wmi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 8952173..3294bb2 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -672,10 +672,7 @@ static void __init find_quirks(void)
static bool has_cap(u32 cap)
{
- if ((interface->capability & cap) != 0)
- return 1;
-
- return 0;
+ return interface->capability & cap;
}
/*
--
2.7.4
next reply other threads:[~2018-08-06 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 20:38 Gustavo A. R. Silva [this message]
2018-08-09 0:44 ` [PATCH v2] platform/x86: acer-wmi: refactor function has_cap joeyli
2018-08-15 9:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806203832.GA11751@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=David.Laight@aculab.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=jlee@suse.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox