* [PATCH v2] platform/x86: acer-wmi: refactor function has_cap
@ 2018-08-06 20:38 Gustavo A. R. Silva
2018-08-09 0:44 ` joeyli
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-06 20:38 UTC (permalink / raw)
To: Lee, Chun-Yi, Darren Hart, Andy Shevchenko, Joe Perches,
David Laight
Cc: platform-driver-x86, linux-kernel, Gustavo A. R. Silva
Refactor function has_cap in order to avoid returning integer
values, when instead it should return booleans.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
Changes in v2:
Remove parentheses and unnecessary code. Thank you all for
the feedback!
drivers/platform/x86/acer-wmi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 8952173..3294bb2 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -672,10 +672,7 @@ static void __init find_quirks(void)
static bool has_cap(u32 cap)
{
- if ((interface->capability & cap) != 0)
- return 1;
-
- return 0;
+ return interface->capability & cap;
}
/*
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] platform/x86: acer-wmi: refactor function has_cap
2018-08-06 20:38 [PATCH v2] platform/x86: acer-wmi: refactor function has_cap Gustavo A. R. Silva
@ 2018-08-09 0:44 ` joeyli
2018-08-15 9:54 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: joeyli @ 2018-08-09 0:44 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Darren Hart, Andy Shevchenko, Joe Perches, David Laight,
platform-driver-x86, linux-kernel
Hi Gustavo,
Sorry for my delay!
On Mon, Aug 06, 2018 at 03:38:32PM -0500, Gustavo A. R. Silva wrote:
> Refactor function has_cap in order to avoid returning integer
> values, when instead it should return booleans.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks for your patch and also thank Andy and Joe's help.
Please feel free to add:
Reviewed-by: "Lee, Chun-Yi" <jlee@suse.com>
Joey Lee
> ---
> Changes in v2:
> Remove parentheses and unnecessary code. Thank you all for
> the feedback!
>
> drivers/platform/x86/acer-wmi.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 8952173..3294bb2 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -672,10 +672,7 @@ static void __init find_quirks(void)
>
> static bool has_cap(u32 cap)
> {
> - if ((interface->capability & cap) != 0)
> - return 1;
> -
> - return 0;
> + return interface->capability & cap;
> }
>
> /*
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] platform/x86: acer-wmi: refactor function has_cap
2018-08-09 0:44 ` joeyli
@ 2018-08-15 9:54 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-08-15 9:54 UTC (permalink / raw)
To: joeyli
Cc: Gustavo A. R. Silva, Darren Hart, Andy Shevchenko, Joe Perches,
David Laight, Platform Driver, Linux Kernel Mailing List
On Thu, Aug 9, 2018 at 3:44 AM, joeyli <jlee@suse.com> wrote:
> Hi Gustavo,
>
> Sorry for my delay!
>
> On Mon, Aug 06, 2018 at 03:38:32PM -0500, Gustavo A. R. Silva wrote:
>> Refactor function has_cap in order to avoid returning integer
>> values, when instead it should return booleans.
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Thanks for your patch and also thank Andy and Joe's help.
>
> Please feel free to add:
>
> Reviewed-by: "Lee, Chun-Yi" <jlee@suse.com>
>
Pushed to my review and testing queue, thanks!
> Joey Lee
>
>> ---
>> Changes in v2:
>> Remove parentheses and unnecessary code. Thank you all for
>> the feedback!
>>
>> drivers/platform/x86/acer-wmi.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> index 8952173..3294bb2 100644
>> --- a/drivers/platform/x86/acer-wmi.c
>> +++ b/drivers/platform/x86/acer-wmi.c
>> @@ -672,10 +672,7 @@ static void __init find_quirks(void)
>>
>> static bool has_cap(u32 cap)
>> {
>> - if ((interface->capability & cap) != 0)
>> - return 1;
>> -
>> - return 0;
>> + return interface->capability & cap;
>> }
>>
>> /*
>> --
>> 2.7.4
>>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-15 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-06 20:38 [PATCH v2] platform/x86: acer-wmi: refactor function has_cap Gustavo A. R. Silva
2018-08-09 0:44 ` joeyli
2018-08-15 9:54 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox