From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
linux-kernel@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 1/2] perf map: synthesize maps only for thread group leader
Date: Tue, 7 Aug 2018 10:15:07 -0300 [thread overview]
Message-ID: <20180807131507.GA4173@kernel.org> (raw)
In-Reply-To: <20180807124334.GD7716@krava>
Em Tue, Aug 07, 2018 at 02:43:34PM +0200, Jiri Olsa escreveu:
> On Tue, Aug 07, 2018 at 12:09:01PM +0300, Konstantin Khlebnikov wrote:
> > Threads share map_groups, all map events are merged into it.
> >
> > Thus we could send mmaps only for thread group leader.
> > Otherwise it took ages to attach and record something from
> > processes with many vmas and threads.
> >
> > Thread group leader could be already dead,
> > but it seems perf cannot handle this case anyway.
>
> nice, could mention in the changelog that we actualy
> synthesize the group leader (if we found one) for the
> thread even if it's not present in the thread_map,
> so the process maps are always in data
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
I'll add your notes, thanks everyone,
- Arnaldo
next prev parent reply other threads:[~2018-08-07 13:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 9:09 [PATCH 1/2] perf map: synthesize maps only for thread group leader Konstantin Khlebnikov
2018-08-07 9:09 ` [PATCH 2/2] perf map: optimize maps__fixup_overlappings() Konstantin Khlebnikov
2018-08-07 12:55 ` Jiri Olsa
2018-08-07 13:15 ` Arnaldo Carvalho de Melo
2018-08-07 14:24 ` [PATCH v2] " Konstantin Khlebnikov
2018-08-07 20:02 ` Arnaldo Carvalho de Melo
2018-08-07 23:03 ` Jiri Olsa
2018-08-08 12:40 ` Arnaldo Carvalho de Melo
2018-08-18 11:42 ` [tip:perf/urgent] perf map: Optimize maps__fixup_overlappings() tip-bot for Konstantin Khlebnikov
2018-08-07 12:43 ` [PATCH 1/2] perf map: synthesize maps only for thread group leader Jiri Olsa
2018-08-07 13:15 ` Arnaldo Carvalho de Melo [this message]
2018-08-18 11:41 ` [tip:perf/urgent] perf map: Synthesize " tip-bot for Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807131507.GA4173@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox