From: ard <ard@kwaak.net>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 0/3] scsi: fcoe: memleak fixes
Date: Tue, 7 Aug 2018 18:04:52 +0200 [thread overview]
Message-ID: <20180807160452.GE23827@kwaak.net> (raw)
In-Reply-To: <20180807092619.GC23827@kwaak.net>
Hi,
On Tue, Aug 07, 2018 at 11:26:19AM +0200, ard wrote:
> So a conclusion of my rambling:
> 1) you either need 6 vn2vn hosts *or* you need more than one 4.14
> kernel in a network to trigger. One of the two. I need to think
> about this. The fact that the 4.14 systems can't see eachother is
> an indicator. I can turn off the FCoE on some other system to
> see if the memleak stops.
I've gone all out:
Ok, deleted everything, long story short:
(for now(!))
PC+steam machine with 4.14 (patched) and 4.16 (upstream,
nodebug): no kmemleaks
Every device sees every device.
Now if I add two odroids running 4.14 (not patched):
The odroids will see *every* device running < 4.14 and vv
The odroids will not see any device running >= 4.14 and vv
The PC starts to kmemleak a lot.
I've removed the two 4.14 odroids again from the FCoE lan, and
upgraded them with a patched 4.14 .
I rebooted the PC with steam (4.16 upstream unpatched) and all
other systems in the lan I mentioned.
To be clear: the steam machine has a dedicated nic for FCoE. All
other systems use a vlan.
I will let that talk with eachother for now.
I fear there is a platform specific thing in the vn2vn chatter
that has changed > 4.9 .
4.14 can communicate with lower revisions, but they can't see
eachother, and whatever they chat about, it induces memory leaks
on the PC.
Oh, another difference is that steam and the PC has targets
assigned. I might try that for the 4.14 too.
Anyway, I will do some cooking and let the current systems chat
with eachother and see if we get a kmemleak making my statement
bogus.
Regards,
Ard
--
.signature not found
next prev parent reply other threads:[~2018-08-07 16:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 13:46 [PATCH 0/3] scsi: fcoe: memleak fixes Johannes Thumshirn
2018-07-31 13:46 ` [PATCH 1/3] fcoe: fix use-after-free in fcoe_ctlr_els_send Johannes Thumshirn
2018-08-01 6:30 ` Hannes Reinecke
2018-07-31 13:46 ` [PATCH 2/3] scsi: fcoe: drop frames in ELS LOGO error path Johannes Thumshirn
2018-08-01 6:30 ` Hannes Reinecke
2018-07-31 13:46 ` [PATCH 3/3] scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO Johannes Thumshirn
2018-08-01 6:31 ` Hannes Reinecke
2018-08-06 9:25 ` [PATCH 0/3] scsi: fcoe: memleak fixes Johannes Thumshirn
2018-08-06 13:22 ` ard
2018-08-06 13:27 ` Johannes Thumshirn
2018-08-06 14:24 ` ard
2018-08-07 6:54 ` Johannes Thumshirn
2018-08-07 9:26 ` ard
2018-08-07 9:57 ` ard
2018-08-07 16:04 ` ard [this message]
2018-08-09 10:01 ` ard
2018-08-09 8:05 ` Johannes Thumshirn
2018-08-09 9:52 ` Martin K. Petersen
2018-08-09 9:56 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807160452.GE23827@kwaak.net \
--to=ard@kwaak.net \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox