From: Matthias Kaehlcke <mka@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bard Liao <bardliao@realtek.com>,
Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Guenter Roeck <groeck@chromium.org>,
Nicolas Boichat <drinkcat@chromium.org>
Subject: Re: [PATCH v2] ASoC: rt5677: Fix initialization of rt5677_of_match.data
Date: Tue, 7 Aug 2018 13:23:06 -0700 [thread overview]
Message-ID: <20180807202306.GE160295@google.com> (raw)
In-Reply-To: <87753f10135e5f0791a6bfecb37ddecf7fd5b977.camel@linux.intel.com>
On Tue, Aug 07, 2018 at 10:13:47PM +0300, Andy Shevchenko wrote:
> On Tue, 2018-08-07 at 10:19 -0700, Matthias Kaehlcke wrote:
> > The driver expects to find the device id in rt5677_of_match.data,
> > however
> > it is currently assigned to rt5677_of_match.type. Fix this.
> >
> > The problem was found with the help of clang:
> > sound/soc/codecs/rt5677.c:5010:36: warning: expression which
> > evaluates to
> > zero treated as a null pointer constant of type 'const void *'
> > [-Wnon-literal-null-conversion]
> > { .compatible = "realtek,rt5677", RT5677 },
> > ^~~~~~
> >
> > Fixes: ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data in the module
> > sources")
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
> While this is correct fix, it seems it was never used.
Or it was used but no problem was noticed because .data was already
0, which happens to be the value of RT5677.
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks
Matthias
next prev parent reply other threads:[~2018-08-07 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 17:19 [PATCH v2] ASoC: rt5677: Fix initialization of rt5677_of_match.data Matthias Kaehlcke
2018-08-07 17:29 ` Guenter Roeck
2018-08-07 19:13 ` Andy Shevchenko
2018-08-07 20:23 ` Matthias Kaehlcke [this message]
2018-08-08 11:08 ` Applied "ASoC: rt5677: Fix initialization of rt5677_of_match.data" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807202306.GE160295@google.com \
--to=mka@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=drinkcat@chromium.org \
--cc=groeck@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox