Re: [PATCH v2] ASoC: rt5677: Fix initialization of rt5677_of_match.data

Andy Shevchenko
2018-08-07T19:13:54Z

On Tue, 2018-08-07 at 10:19 -0700, Matthias Kaehlcke wrote:
> The driver expects to find the device id in rt5677_of_match.data,
> however
> it is currently assigned to rt5677_of_match.type. Fix this.
>
> The problem was found with the help of clang:
> sound/soc/codecs/rt5677.c:5010:36: warning: expression which
> evaluates to
> zero treated as a null pointer constant of type 'const void *'
> [-Wnon-literal-null-conversion]
> { .compatible = "realtek,rt5677", RT5677 },
> ^~~~~~
>
> Fixes: ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data in the module
> sources")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

While this is correct fix, it seems it was never used.

Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> static const struct of_device_id rt5677_of_match[] = {
> - { .compatible = "realtek,rt5677", RT5677 },
> + { .compatible = "realtek,rt5677", .data = (const void *)RT5677
> },
> { }
> };
> MODULE_DEVICE_TABLE(of, rt5677_of_match);

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy