From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 04/17] staging:rtl8192u: Rename eqMacAddr macro - Style
Date: Tue, 7 Aug 2018 22:12:42 +0100 [thread overview]
Message-ID: <20180807211255.29343-5-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180807211255.29343-1-johnfwhitmore@gmail.com>
The eqMacAddr(a, b) macro causes a checkpatch issue, due to CamelCase
naming, so has been renamed to eq_mac_addr(a, b).
This is a coding style change which should not impact on runtime code
execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 4 ++--
drivers/staging/rtl8192u/r8192U_core.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index 363a6bed18dd..81a0bb20f662 100644
--- a/drivers/staging/rtl8192u/ieee80211/dot11d.h
+++ b/drivers/staging/rtl8192u/ieee80211/dot11d.h
@@ -30,7 +30,7 @@ struct rt_dot11d_info {
enum dot11d_state state;
};
-#define eqMacAddr(a, b) (((a)[0] == (b)[0] && \
+#define eq_mac_addr(a, b) (((a)[0] == (b)[0] && \
(a)[1] == (b)[1] && (a)[2] == (b)[2] && (a)[3] == (b)[3] && \
(a)[4] == (b)[4] && (a)[5] == (b)[5]) ? 1 : 0)
#define cpMacAddr(des, src) ((des)[0] = (src)[0], \
@@ -42,7 +42,7 @@ struct rt_dot11d_info {
#define IS_DOT11D_ENABLE(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->enabled)
#define IS_COUNTRY_IE_VALID(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->country_ie_len > 0)
-#define IS_EQUAL_CIE_SRC(__pIeeeDev, __pTa) eqMacAddr(GET_DOT11D_INFO(__pIeeeDev)->country_ie_src_addr, __pTa)
+#define IS_EQUAL_CIE_SRC(__pIeeeDev, __pTa) eq_mac_addr(GET_DOT11D_INFO(__pIeeeDev)->country_ie_src_addr, __pTa)
#define UPDATE_CIE_SRC(__pIeeeDev, __pTa) cpMacAddr(GET_DOT11D_INFO(__pIeeeDev)->country_ie_src_addr, __pTa)
#define GET_CIE_WATCHDOG(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->country_ie_watchdog)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index e218b5c20642..b7b4694c1f27 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -4460,15 +4460,15 @@ static void TranslateRxSignalStuff819xUsb(struct sk_buff *skb,
/* Check if the received packet is acceptable. */
bpacket_match_bssid = (type != IEEE80211_FTYPE_CTL) &&
- (eqMacAddr(priv->ieee80211->current_network.bssid, (fc & IEEE80211_FCTL_TODS) ? hdr->addr1 : (fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 : hdr->addr3))
+ (eq_mac_addr(priv->ieee80211->current_network.bssid, (fc & IEEE80211_FCTL_TODS) ? hdr->addr1 : (fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 : hdr->addr3))
&& (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV);
bpacket_toself = bpacket_match_bssid &
- (eqMacAddr(praddr, priv->ieee80211->dev->dev_addr));
+ (eq_mac_addr(praddr, priv->ieee80211->dev->dev_addr));
if (WLAN_FC_GET_FRAMETYPE(fc) == IEEE80211_STYPE_BEACON)
bPacketBeacon = true;
if (WLAN_FC_GET_FRAMETYPE(fc) == IEEE80211_STYPE_BLOCKACK) {
- if ((eqMacAddr(praddr, dev->dev_addr)))
+ if ((eq_mac_addr(praddr, dev->dev_addr)))
bToSelfBA = true;
}
--
2.18.0
next prev parent reply other threads:[~2018-08-07 21:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 21:12 [PATCH 00/17] staging:rtl8192u: Coding style changes John Whitmore
2018-08-07 21:12 ` [PATCH 01/17] staging:rtl8192u: Remove stale comment - Style John Whitmore
2018-08-07 21:12 ` [PATCH 02/17] staging:rtl8192u: Add spaces around '+' operator " John Whitmore
2018-08-07 21:12 ` [PATCH 03/17] staging:rtl8192u: Remove unused macro definitions " John Whitmore
2018-08-07 21:12 ` John Whitmore [this message]
2018-08-08 8:12 ` [PATCH 04/17] staging:rtl8192u: Rename eqMacAddr macro " Joe Perches
2018-08-08 8:52 ` John Whitmore
2018-08-07 21:12 ` [PATCH 05/17] staging:rtl8192u: Rename cpMacAddr Macro " John Whitmore
2018-08-08 8:14 ` Joe Perches
2018-08-07 21:12 ` [PATCH 06/17] staging:rtl8192u: Rename macro parameter __pIeeeDev " John Whitmore
2018-08-07 21:12 ` [PATCH 07/17] staging:rtl8192u: Rename __pTa " John Whitmore
2018-08-07 21:12 ` [PATCH 08/17] staging:rtl8192u: Lines should not end with a '(' " John Whitmore
2018-08-07 21:12 ` [PATCH 09/17] staging:rtl8192u: Rename Dot11d_Init " John Whitmore
2018-08-07 21:12 ` [PATCH 10/17] staging:rtl8192u: Rename Dot11d_Reset " John Whitmore
2018-08-07 21:12 ` [PATCH 11/17] staging:rtl8192u: Rename Dot11d_UpdateCountryIe " John Whitmore
2018-08-07 21:12 ` [PATCH 12/17] staging:rtl8192u: Rename dot11d_update_country_ie() parameters " John Whitmore
2018-08-07 21:12 ` [PATCH 13/17] staging:rtl8192u: Rename DOT11D_GetMaxTxPwrInDbm " John Whitmore
2018-08-07 21:12 ` [PATCH 14/17] staging:rtl8192u: Rename Channel " John Whitmore
2018-08-07 21:12 ` [PATCH 15/17] staging:rtl8192u: Rename DOT11D_ScanComplete " John Whitmore
2018-08-07 21:12 ` [PATCH 16/17] staging:rtl8192u: Rename IsLegalChannel " John Whitmore
2018-08-07 21:12 ` [PATCH 17/17] staging:rtl8192u: Rename ToLegalChannel " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807211255.29343-5-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox