public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 06/17] staging:rtl8192u: Rename macro parameter __pIeeeDev - Style
Date: Tue,  7 Aug 2018 22:12:44 +0100	[thread overview]
Message-ID: <20180807211255.29343-7-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180807211255.29343-1-johnfwhitmore@gmail.com>

Multiple macros, defined in dot11d.h, use the variable __pIeeeDev as a
parameter. This name causes a checkpatch issue due to its use of
CamelCase naming. The parameter name has been changed to ieee_dev to
clear this issue.

This is a coding style change which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/dot11d.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index a53f6454262a..01adf747f7c8 100644
--- a/drivers/staging/rtl8192u/ieee80211/dot11d.h
+++ b/drivers/staging/rtl8192u/ieee80211/dot11d.h
@@ -37,17 +37,17 @@ struct rt_dot11d_info {
 	(des)[1] = (src)[1], (des)[2] = (src)[2], \
 	(des)[3] = (src)[3], (des)[4] = (src)[4], \
 	(des)[5] = (src)[5])
-#define GET_DOT11D_INFO(__pIeeeDev) ((struct rt_dot11d_info *)((__pIeeeDev)->pDot11dInfo))
+#define GET_DOT11D_INFO(ieee_dev) ((struct rt_dot11d_info *)((ieee_dev)->pDot11dInfo))
 
-#define IS_DOT11D_ENABLE(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->enabled)
-#define IS_COUNTRY_IE_VALID(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->country_ie_len > 0)
+#define IS_DOT11D_ENABLE(ieee_dev) (GET_DOT11D_INFO(ieee_dev)->enabled)
+#define IS_COUNTRY_IE_VALID(ieee_dev) (GET_DOT11D_INFO(ieee_dev)->country_ie_len > 0)
 
-#define IS_EQUAL_CIE_SRC(__pIeeeDev, __pTa) eq_mac_addr(GET_DOT11D_INFO(__pIeeeDev)->country_ie_src_addr, __pTa)
-#define UPDATE_CIE_SRC(__pIeeeDev, __pTa) cp_mac_addr(GET_DOT11D_INFO(__pIeeeDev)->country_ie_src_addr, __pTa)
+#define IS_EQUAL_CIE_SRC(ieee_dev, __pTa) eq_mac_addr(GET_DOT11D_INFO(ieee_dev)->country_ie_src_addr, __pTa)
+#define UPDATE_CIE_SRC(ieee_dev, __pTa) cp_mac_addr(GET_DOT11D_INFO(ieee_dev)->country_ie_src_addr, __pTa)
 
-#define GET_CIE_WATCHDOG(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->country_ie_watchdog)
-#define RESET_CIE_WATCHDOG(__pIeeeDev) (GET_CIE_WATCHDOG(__pIeeeDev) = 0)
-#define UPDATE_CIE_WATCHDOG(__pIeeeDev) (++GET_CIE_WATCHDOG(__pIeeeDev))
+#define GET_CIE_WATCHDOG(ieee_dev) (GET_DOT11D_INFO(ieee_dev)->country_ie_watchdog)
+#define RESET_CIE_WATCHDOG(ieee_dev) (GET_CIE_WATCHDOG(ieee_dev) = 0)
+#define UPDATE_CIE_WATCHDOG(ieee_dev) (++GET_CIE_WATCHDOG(ieee_dev))
 
 void
 Dot11d_Init(
-- 
2.18.0


  parent reply	other threads:[~2018-08-07 21:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07 21:12 [PATCH 00/17] staging:rtl8192u: Coding style changes John Whitmore
2018-08-07 21:12 ` [PATCH 01/17] staging:rtl8192u: Remove stale comment - Style John Whitmore
2018-08-07 21:12 ` [PATCH 02/17] staging:rtl8192u: Add spaces around '+' operator " John Whitmore
2018-08-07 21:12 ` [PATCH 03/17] staging:rtl8192u: Remove unused macro definitions " John Whitmore
2018-08-07 21:12 ` [PATCH 04/17] staging:rtl8192u: Rename eqMacAddr macro " John Whitmore
2018-08-08  8:12   ` Joe Perches
2018-08-08  8:52     ` John Whitmore
2018-08-07 21:12 ` [PATCH 05/17] staging:rtl8192u: Rename cpMacAddr Macro " John Whitmore
2018-08-08  8:14   ` Joe Perches
2018-08-07 21:12 ` John Whitmore [this message]
2018-08-07 21:12 ` [PATCH 07/17] staging:rtl8192u: Rename __pTa " John Whitmore
2018-08-07 21:12 ` [PATCH 08/17] staging:rtl8192u: Lines should not end with a '(' " John Whitmore
2018-08-07 21:12 ` [PATCH 09/17] staging:rtl8192u: Rename Dot11d_Init " John Whitmore
2018-08-07 21:12 ` [PATCH 10/17] staging:rtl8192u: Rename Dot11d_Reset " John Whitmore
2018-08-07 21:12 ` [PATCH 11/17] staging:rtl8192u: Rename Dot11d_UpdateCountryIe " John Whitmore
2018-08-07 21:12 ` [PATCH 12/17] staging:rtl8192u: Rename dot11d_update_country_ie() parameters " John Whitmore
2018-08-07 21:12 ` [PATCH 13/17] staging:rtl8192u: Rename DOT11D_GetMaxTxPwrInDbm " John Whitmore
2018-08-07 21:12 ` [PATCH 14/17] staging:rtl8192u: Rename Channel " John Whitmore
2018-08-07 21:12 ` [PATCH 15/17] staging:rtl8192u: Rename DOT11D_ScanComplete " John Whitmore
2018-08-07 21:12 ` [PATCH 16/17] staging:rtl8192u: Rename IsLegalChannel " John Whitmore
2018-08-07 21:12 ` [PATCH 17/17] staging:rtl8192u: Rename ToLegalChannel " John Whitmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180807211255.29343-7-johnfwhitmore@gmail.com \
    --to=johnfwhitmore@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox