From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E487C46470 for ; Tue, 7 Aug 2018 22:17:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4111215A3 for ; Tue, 7 Aug 2018 22:17:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4111215A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726895AbeHHAd7 (ORCPT ); Tue, 7 Aug 2018 20:33:59 -0400 Received: from mga04.intel.com ([192.55.52.120]:39478 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726537AbeHHAd7 (ORCPT ); Tue, 7 Aug 2018 20:33:59 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2018 15:17:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,456,1526367600"; d="scan'208";a="73564441" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.126]) by orsmga003.jf.intel.com with ESMTP; 07 Aug 2018 15:17:25 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 4D79D3013C5; Tue, 7 Aug 2018 15:17:25 -0700 (PDT) Date: Tue, 7 Aug 2018 15:17:25 -0700 From: Andi Kleen To: Thomas Gleixner Cc: Peter Zijlstra , Dave Hansen , kan.liang@linux.intel.com, mingo@redhat.com, len.brown@intel.com, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] x86/cpu: Rename Denverton and Gemini Lake Message-ID: <20180807221725.GU4238@tassilo.jf.intel.com> References: <1533662247-17575-1-git-send-email-kan.liang@linux.intel.com> <1b7cb461-5321-86cf-3031-5ff545c3dc42@linux.intel.com> <20180807174851.GJ2494@hirez.programming.kicks-ass.net> <20180807183736.GR4238@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Which simply does not work. Look at Goldmont Fam 6 Model 5C. The SoCs > with that Fam/Model combination are: > > - Apollo Lake > - Broxton (has two platforms: Morganfield and Willowtrail) Right pick one. The others are the same for software purposes and can be handled in the same way. > > It's even worse with Silvermont. > > So no, the interesting information is the UARCH and the variant of that, With Uarch you mean the core uarch? That doesn't really work for something like Silvermont or Goldmont. > e.g. UARCH_CLIENT, UARCH_SERVER, UARCH_WHATEVER. All the magic Code Names Right your scheme totally doesn't work on Silvermont because there are multiple client variants. > and their platform variants are not interesting at all for the Fam/Model > information. You're right platform is misleading. I think the right level are SOCs, because that matches the how the model numbers are allocated. On Big Core *Lakes are all unique SOCs. -Andi