From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Todd Poynor <toddpoynor@gmail.com>
Cc: Rob Springer <rspringer@google.com>,
John Joseph <jnjoseph@google.com>,
Ben Chan <benchan@chromium.org>,
devel@driverdev.osuosl.org, Todd Poynor <toddpoynor@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/15] staging: gasket: unwrap pci core and more
Date: Wed, 8 Aug 2018 11:20:32 +0200 [thread overview]
Message-ID: <20180808092032.GA32636@kroah.com> (raw)
In-Reply-To: <20180805200749.116693-1-toddpoynor@gmail.com>
On Sun, Aug 05, 2018 at 01:07:34PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@google.com>
>
> Stop wrapping PCI core calls like probe, enable, remove, etc. in the
> gasket framework, move these calls to the device driver instead. Have
> gasket drivers call into framework on init, enable, disable,
> etc. sequences, rather than the other way around. Remove the
> gasket-to-device callbacks associated with these sequences.
>
> Plus a few other fixes and cleanups.
>
> Todd Poynor (15):
> staging: gasket: sysfs: clean up state if ENOMEM removing mapping
> staging: gasket: core: move core PCI calls to device drivers
> staging: gasket: apex: move PCI core calls to apex driver
> staging: gasket: core: convert remaining info logs to debug
> staging: gasket: core: remove device enable and disable callbacks
> staging: gasket: apex: remove device enable and disable callbacks
> staging: gasket: core: let device driver enable/disable gasket device
> staging: gasket: apex: enable/disable gasket device from apex
> staging: gasket: core: delete device add and remove callbacks
> staging: gasket: apex: fold device add/remove logic inline
> staging: gasket: core: remove sysfs setup and cleanup callbacks
> staging: gasket: apex: move sysfs setup code to probe function
> staging: gasket: core: protect against races during unregister
> staging: gasket: apex: place in low power reset until opened
> staging: gasket: core: remove incorrect extraneous comment
>
> drivers/staging/gasket/apex_driver.c | 145 +++++++++++++++++---------
> drivers/staging/gasket/gasket_core.c | 140 ++++++-------------------
> drivers/staging/gasket/gasket_core.h | 82 +++------------
> drivers/staging/gasket/gasket_sysfs.c | 13 ++-
> 4 files changed, 148 insertions(+), 232 deletions(-)
Nice cleanups!
prev parent reply other threads:[~2018-08-08 9:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 20:07 [PATCH 00/15] staging: gasket: unwrap pci core and more Todd Poynor
2018-08-05 20:07 ` [PATCH 01/15] staging: gasket: sysfs: clean up state if ENOMEM removing mapping Todd Poynor
2018-08-05 20:07 ` [PATCH 02/15] staging: gasket: core: move core PCI calls to device drivers Todd Poynor
2018-08-05 20:07 ` [PATCH 03/15] staging: gasket: apex: move PCI core calls to apex driver Todd Poynor
2018-08-05 20:07 ` [PATCH 04/15] staging: gasket: core: convert remaining info logs to debug Todd Poynor
2018-08-08 9:17 ` Greg Kroah-Hartman
2018-08-05 20:07 ` [PATCH 05/15] staging: gasket: core: remove device enable and disable callbacks Todd Poynor
2018-08-05 20:07 ` [PATCH 06/15] staging: gasket: apex: " Todd Poynor
2018-08-05 20:07 ` [PATCH 07/15] staging: gasket: core: let device driver enable/disable gasket device Todd Poynor
2018-08-05 20:07 ` [PATCH 08/15] staging: gasket: apex: enable/disable gasket device from apex Todd Poynor
2018-08-05 20:07 ` [PATCH 09/15] staging: gasket: core: delete device add and remove callbacks Todd Poynor
2018-08-05 20:07 ` [PATCH 10/15] staging: gasket: apex: fold device add/remove logic inline Todd Poynor
2018-08-05 20:07 ` [PATCH 11/15] staging: gasket: core: remove sysfs setup and cleanup callbacks Todd Poynor
2018-08-05 20:07 ` [PATCH 12/15] staging: gasket: apex: move sysfs setup code to probe function Todd Poynor
2018-08-05 20:07 ` [PATCH 13/15] staging: gasket: core: protect against races during unregister Todd Poynor
2018-08-05 20:07 ` [PATCH 14/15] staging: gasket: apex: place in low power reset until opened Todd Poynor
2018-08-05 20:07 ` [PATCH 15/15] staging: gasket: core: remove incorrect extraneous comment Todd Poynor
2018-08-08 9:20 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808092032.GA32636@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=toddpoynor@gmail.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox