From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1840C46470 for ; Wed, 8 Aug 2018 12:40:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 953A3219E6 for ; Wed, 8 Aug 2018 12:40:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 953A3219E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727123AbeHHPAK (ORCPT ); Wed, 8 Aug 2018 11:00:10 -0400 Received: from mga06.intel.com ([134.134.136.31]:19078 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726680AbeHHPAK (ORCPT ); Wed, 8 Aug 2018 11:00:10 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 05:40:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,457,1526367600"; d="scan'208";a="222943267" Received: from sofia.sh.intel.com (HELO sofia) ([10.239.147.112]) by orsmga004.jf.intel.com with ESMTP; 08 Aug 2018 05:40:12 -0700 Date: Wed, 8 Aug 2018 20:39:22 +0800 From: "Liu, Changcheng" To: Steven Rostedt Cc: broonie@opensource.wolfsonmicro.com, mingo@redhat.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] ASoC: trace: track dapm type in snd_soc_dapm_widget Message-ID: <20180808123921.GA145536@sofia> References: <20180808092927.GA144203@sofia> <20180808082412.20f7bd92@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180808082412.20f7bd92@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08:24 Wed 08 Aug, Steven Rostedt wrote: > On Wed, 8 Aug 2018 17:29:27 +0800 > "Liu, Changcheng" wrote: > > > Track snd_soc_dapm_widget:id which is used as dapm > > sequence index in dapm_down_seq/dapm_up_seq. It's > > useful for checking dapm seq after tracking it. > > > > Signed-off-by: Liu Changcheng > > > > diff --git a/include/trace/events/asoc.h b/include/trace/events/asoc.h > > index 40c300f..0bc935b 100644 > > --- a/include/trace/events/asoc.h > > +++ b/include/trace/events/asoc.h > > @@ -92,16 +92,18 @@ DECLARE_EVENT_CLASS(snd_soc_dapm_widget, > > > > TP_STRUCT__entry( > > __string( name, w->name ) > > + __field( int, id ) > > __field( int, val ) > > ), > > > > TP_fast_assign( > > __assign_str(name, w->name); > > + __entry->id = w->id; > > __entry->val = val; > > ), > > > > - TP_printk("widget=%s val=%d", __get_str(name), > > - (int)__entry->val) > > + TP_printk("widget=%s dapm_id=%d val=%d", __get_str(name), > > + (int)__entry->id, (int)__entry->val) > > Not sure why it was there before, but the (int) typecast isn't needed > in either case. __field(int, val) makes __entry->val of type int. Same > for id. > > -- Steve @Steve: This patch aims at tracking the dapm up/down sequence. For the (int) typecast format problem, what do you think of using another seperate patch to resolve it? -- Changcheng > > > ); > > > > DEFINE_EVENT(snd_soc_dapm_widget, snd_soc_dapm_widget_power, >