From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH v2 03/15] staging:rtl8192u: Replace magic number 6 with ETH_ALEN - Style
Date: Wed, 8 Aug 2018 22:00:24 +0100 [thread overview]
Message-ID: <20180808210036.22580-4-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180808210036.22580-1-johnfwhitmore@gmail.com>
The array size 6 represents the length of an Ethernet address so the
magic number has been replaced with the defined constant representing
that length.
This is a coding style change which should not impact runtime code
execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index 14879bc0fe6b..4ef609abc68b 100644
--- a/drivers/staging/rtl8192u/ieee80211/dot11d.h
+++ b/drivers/staging/rtl8192u/ieee80211/dot11d.h
@@ -20,7 +20,7 @@ struct rt_dot11d_info {
u16 country_ie_len; /* > 0 if country_ie_buf[] contains valid country information element. */
/* country_ie_src_addr u16 aligned for comparison and copy */
- u8 country_ie_src_addr[6]; /* Source AP of the country IE. */
+ u8 country_ie_src_addr[ETH_ALEN]; /* Source AP of the country IE. */
u8 country_ie_buf[MAX_IE_LEN];
u8 country_ie_watchdog;
--
2.18.0
next prev parent reply other threads:[~2018-08-08 21:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 21:00 [PATCH v2 00/15] staging:rtl8192u: Coding style John Whitmore
2018-08-08 21:00 ` [PATCH v2 01/15] staging:rtl8192u: Remove macro eqMacAddr - Style John Whitmore
2018-08-08 22:14 ` Joe Perches
2018-08-09 8:44 ` John Whitmore
2018-08-08 21:00 ` [PATCH v2 02/15] staging:rtl8192u: Remove macro cpMacAddr " John Whitmore
2018-08-08 21:00 ` John Whitmore [this message]
2018-08-08 21:00 ` [PATCH v2 04/15] staging:rtl8192u: Rename macro parameter __pIeeeDev " John Whitmore
2018-08-08 21:00 ` [PATCH v2 05/15] staging:rtl8192u: Rename __pTa " John Whitmore
2018-08-08 21:00 ` [PATCH v2 06/15] staging:rtl8192u: Lines should not end with a '(' " John Whitmore
2018-08-08 21:00 ` [PATCH v2 07/15] staging:rtl8192u: Rename Dot11d_Init " John Whitmore
2018-08-08 21:00 ` [PATCH v2 08/15] staging:rtl8192u: Rename Dot11d_Reset " John Whitmore
2018-08-08 21:00 ` [PATCH v2 09/15] staging:rtl8192u: Rename Dot11d_UpdateCountryIe " John Whitmore
2018-08-08 21:00 ` [PATCH v2 10/15] staging:rtl8192u: Rename dot11d_update_country_ie() parameters " John Whitmore
2018-08-08 21:00 ` [PATCH v2 11/15] staging:rtl8192u: Rename DOT11D_GetMaxTxPwrInDbm " John Whitmore
2018-08-08 21:00 ` [PATCH v2 12/15] staging:rtl8192u: Rename Channel " John Whitmore
2018-08-08 21:00 ` [PATCH v2 13/15] staging:rtl8192u: Rename DOT11D_ScanComplete " John Whitmore
2018-08-08 21:00 ` [PATCH v2 14/15] staging:rtl8192u: Rename IsLegalChannel " John Whitmore
2018-08-08 21:00 ` [PATCH v2 15/15] staging:rtl8192u: Rename ToLegalChannel " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808210036.22580-4-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox