From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FAFC4646D for ; Wed, 8 Aug 2018 21:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C63821A9A for ; Wed, 8 Aug 2018 21:02:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C63821A9A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732294AbeHHXXn (ORCPT ); Wed, 8 Aug 2018 19:23:43 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40325 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730169AbeHHXXn (ORCPT ); Wed, 8 Aug 2018 19:23:43 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 7D34D80636; Wed, 8 Aug 2018 23:02:16 +0200 (CEST) Date: Wed, 8 Aug 2018 23:02:16 +0200 From: Pavel Machek To: Dan Murphy Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver Message-ID: <20180808210215.GA15831@amd> References: <20180807160442.8937-1-dmurphy@ti.com> <20180808195903.GB20912@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DocE+STaALJfprDB" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >> + - #size-cells : 0 > >> + - control-bank-cfg - : Indicates which sink is connected to which co= ntrol bank > >> + 0 - All HVLED outputs are controlled by bank A > >> + 1 - HVLED1 is controlled bank B, HVLED2/3 are controlled by bank A > >> + 2 - HVLED2 is controlled bank B, HVLED1/3 are controlled by bank A > >> + 3 - HVLED1/2 are controlled by bank B, HVLED3 is controlled by bank= A > >> + 4 - HVLED3 is controlled by bank B, HVLED1/2 are controlled by bank= A > >> + 5 - HVLED1/3 is controlled by bank B, HVLED2 is controlled by bank A > >> + 6 - (default) HVLED1 is controlled by bank A, HVLED2/3 are controll= ed by bank B > >> + 7 - All HVLED outputs are controlled by bank B > >=20 > > This is quite long way to describe a bitmask, no? Could we make > > it so that control-bank-cfg is not needed? >=20 > The problem we have here is there is a potential to control > 3 different LED string but only 2 sinks. So control bank A can control 2= LED strings and control > bank b can control 1 LED string. =20 >=20 Can we forget about the LED strings, and just expose the sinks as Linux LED devices? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --DocE+STaALJfprDB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAltrWlcACgkQMOfwapXb+vJXKACeNsGqbtuMFPW3Jtr+9/aN7qRf YZ8An3/jYlRDulqvn4ZuE/VdMsI+74Bq =XbIL -----END PGP SIGNATURE----- --DocE+STaALJfprDB--