From: Alan Kao <alankao@andestech.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <vincentc@andestech.com>, Andrew Waterman <andrew@sifive.com>,
"Arnd Bergmann" <arnd@arndb.de>, <greentime@andestech.com>,
<zong@andestech.com>, Darius Rad <darius@bluespec.com>,
Palmer Dabbelt <palmer@sifive.com>,
<linux-kernel@vger.kernel.org>, Albert Ou <albert@sifive.com>,
<linux-riscv@lists.infradead.org>, <nickhu@andestech.com>
Subject: Re: [PATCH v5 5/5] Auto-detect whether a FPU exists
Date: Thu, 9 Aug 2018 14:43:36 +0800 [thread overview]
Message-ID: <20180809064336.GA18746@andestech.com> (raw)
In-Reply-To: <20180809063124.GA26062@infradead.org>
On Wed, Aug 08, 2018 at 11:31:24PM -0700, Christoph Hellwig wrote:
> > extern unsigned long elf_hwcap;
> > +extern bool has_fpu;
> > #endif
>
> Doesn't this conflict with the !CONFIG_CPU stub in switch_to.h?
switch_to.h did include asm/hwcap.h, but the !CONFIG_FPU stub
+#define has_fpu false
always shows later than
+extern bool has fpu
so actually no warning during compilation.
>
> It seems like we should only have this definition in one place to start
> with.
It does look a little bit weird. Should I send a v6 for this?
>
> Otherwise this looks fine to me:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
Thanks for all the feedback.
Alan
next prev parent reply other threads:[~2018-08-09 6:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 6:26 [PATCH v5 0/5] riscv: Add support to no-FPU systems Alan Kao
2018-08-09 6:26 ` [PATCH v5 1/5] Extract FPU context operations from entry.S Alan Kao
2018-08-09 6:26 ` [PATCH v5 2/5] Refactor FPU code in signal setup/return procedures Alan Kao
2018-08-09 6:26 ` [PATCH v5 3/5] Cleanup ISA string setting Alan Kao
2018-08-09 6:26 ` [PATCH v5 4/5] Allow to disable FPU support Alan Kao
2018-08-09 6:26 ` [PATCH v5 5/5] Auto-detect whether a FPU exists Alan Kao
2018-08-09 6:31 ` Christoph Hellwig
2018-08-09 6:43 ` Alan Kao [this message]
2018-08-09 7:02 ` Christoph Hellwig
2018-08-09 7:33 ` Alan Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809064336.GA18746@andestech.com \
--to=alankao@andestech.com \
--cc=albert@sifive.com \
--cc=andrew@sifive.com \
--cc=arnd@arndb.de \
--cc=darius@bluespec.com \
--cc=greentime@andestech.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nickhu@andestech.com \
--cc=palmer@sifive.com \
--cc=vincentc@andestech.com \
--cc=zong@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox