Re: [PATCH RFC 01/10] rcu: Make CONFIG_SRCU unconditionally enabled

Kirill Tkhai
2018-08-08T09:46:57Z

On 08.08.2018 04:05, Stephen Rothwell wrote:
> Hi Kirill,
>
> On Tue, 07 Aug 2018 18:37:36 +0300 Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>>
>> This patch kills all CONFIG_SRCU defines and
>> the code under !CONFIG_SRCU.
>>
>> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
>> ---
>> drivers/base/core.c | 42 --------------------
>> include/linux/device.h | 2 -
>> include/linux/rcutiny.h | 4 --
>> include/linux/srcu.h | 5 --
>> kernel/notifier.c | 3 -
>> kernel/rcu/Kconfig | 12 +-----
>> kernel/rcu/tree.h | 5 --
>> kernel/rcu/update.c | 4 --
>> .../selftests/rcutorture/doc/TREE_RCU-kconfig.txt | 5 --
>> 9 files changed, 3 insertions(+), 79 deletions(-)
>
> You left quite a few "select SRCU" statements scattered across Kconfig
> files:
>
> $ git grep -l 'select SRCU' '*Kconfig*'
> arch/arm/kvm/Kconfig
> arch/arm64/kvm/Kconfig
> arch/mips/kvm/Kconfig
> arch/powerpc/kvm/Kconfig
> arch/s390/kvm/Kconfig
> arch/x86/Kconfig
> arch/x86/kvm/Kconfig
> block/Kconfig
> drivers/clk/Kconfig
> drivers/cpufreq/Kconfig
> drivers/dax/Kconfig
> drivers/devfreq/Kconfig
> drivers/hwtracing/stm/Kconfig
> drivers/md/Kconfig
> drivers/net/Kconfig
> drivers/opp/Kconfig
> fs/btrfs/Kconfig
> fs/notify/Kconfig
> fs/quota/Kconfig
> init/Kconfig
> kernel/rcu/Kconfig
> kernel/rcu/Kconfig.debug
> mm/Kconfig
> security/tomoyo/Kconfig

Yeah, thanks, Stephen.