From: Mark Brown <broonie@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: adau1761: Mark expected switch fall-though
Date: Thu, 9 Aug 2018 10:31:00 +0100 [thread overview]
Message-ID: <20180809093100.GC6132@sirena.org.uk> (raw)
In-Reply-To: <20180808192213.GA27872@embeddedor.com>
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Wed, Aug 08, 2018 at 02:22:13PM -0500, Gustavo A. R. Silva wrote:
> @@ -518,7 +518,8 @@ static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component)
> ARRAY_SIZE(adau1761_jack_detect_controls));
> if (ret)
> return ret;
> - case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE: /* fallthrough */
> + /* fall through */
> + case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE:
> ret = snd_soc_dapm_add_routes(dapm, adau1761_no_dmic_routes,
> ARRAY_SIZE(adau1761_no_dmic_routes));
> if (ret)
Again, are you *sure* here?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-08-09 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 19:22 [PATCH] ASoC: adau1761: Mark expected switch fall-though Gustavo A. R. Silva
2018-08-09 9:31 ` Mark Brown [this message]
2018-08-09 11:19 ` [alsa-devel] " Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809093100.GC6132@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=gustavo@embeddedor.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox