From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911F6C46460 for ; Thu, 9 Aug 2018 11:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4045D21D68 for ; Thu, 9 Aug 2018 11:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GT2/a/TE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4045D21D68 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730660AbeHIOGr (ORCPT ); Thu, 9 Aug 2018 10:06:47 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:50703 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730119AbeHIOGr (ORCPT ); Thu, 9 Aug 2018 10:06:47 -0400 Received: by mail-wm0-f66.google.com with SMTP id s12-v6so6056140wmc.0; Thu, 09 Aug 2018 04:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mUQRdaVRkeUyjH5TNmR3uZ8MsrqB3UjhyA0wY6v2nBI=; b=GT2/a/TE4qICo+QiezmJEAyflKlhbL96JeGUbSEO3t1DCkOnqHeZu3yTlz2RLGCT6C qRYouYjRunpUlIynIeas4hPl6o/qczGmfNE5yrtN4I16dhbn4UY0Bv1h0SnCWyTWLBO/ NYGChNbrsiRENd1eV7NcKBxQ5QN2ZFaLR8SuE1h54BWFakB7u6d15I0cC3021iFGYNrJ A3/4q726HUkIKYF9DF1gNbU2jo17wKAvFr8OrXlCZSU7yOXyMLeQo4ZcEeySG1BTXqoy CnAQ6QwFPQnDSTT8ca42gP0Ou9bWZjNrhapkDU0BQQDY+DDQfcGwmGLdNmHdvQsT+DUR EgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mUQRdaVRkeUyjH5TNmR3uZ8MsrqB3UjhyA0wY6v2nBI=; b=K4fXK47ZVe1Xb12rSpCnugzF3wJY+IyiMMvFgeIzwgmUqxD2d2buXqZGhdBr+XKvm2 JlXehro7kWa5XIw/EzFaYi6AaM2ezc46n6gj1WsG5TQ78tKb9tlzktxxmZ3dRnMjDz5k Tr24doXjYUdoAl66uiVCoH0FpeESJ3RExZYLrB0wliYPSU7wc8FcYzHsMGOaj1fpNxoK zUaP3Z6EYw3UMMHtsqd8wZ+lUI/zqKv419slmzBrJtIWpe1+z4uZG6Ug9DHE8WyaZfEm /bz2mFiLoB4gUM0a1o5Gk7kgnA/iLWK5gg16pgoQJKcqwYufvMIAszGnpPK1CKZ+EWSn eEfg== X-Gm-Message-State: AOUpUlHKPqCTWdI4zwLIR7fRb9+RjFjwe/1BWMIdWvJwyMhfG/9B1pSO Palh04sWfiRz8RTsXK5LiwI= X-Google-Smtp-Source: AA+uWPzolp3jgmy8WbQV64osD4n6AnLYgF5HkIzpmWeMRAMsM2i5q4SXvLvJSHE/lLvRdMgTnQZcvg== X-Received: by 2002:a1c:dc89:: with SMTP id t131-v6mr1502609wmg.50.1533814936164; Thu, 09 Aug 2018 04:42:16 -0700 (PDT) Received: from localhost (pD9E51C80.dip0.t-ipconnect.de. [217.229.28.128]) by smtp.gmail.com with ESMTPSA id u7-v6sm6123993wrq.13.2018.08.09.04.42.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Aug 2018 04:42:15 -0700 (PDT) Date: Thu, 9 Aug 2018 13:42:14 +0200 From: Thierry Reding To: Aapo Vienamo Cc: Ulf Hansson , Rob Herring , Mark Rutland , Jonathan Hunter , Adrian Hunter , Mikko Perttunen , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] mmc: tegra: Parse and program DQS trim value Message-ID: <20180809114214.GK21639@ulmo> References: <1533650404-18125-1-git-send-email-avienamo@nvidia.com> <1533650404-18125-3-git-send-email-avienamo@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7ArrI7P/b+va1vZ8" Content-Disposition: inline In-Reply-To: <1533650404-18125-3-git-send-email-avienamo@nvidia.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7ArrI7P/b+va1vZ8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Two more comments... On Tue, Aug 07, 2018 at 04:59:58PM +0300, Aapo Vienamo wrote: > Parse and program the HS400 DQS trim value from dt. Program a fallback > value in case the property is missing. "dt" -> "DT" because it is an abbreviation. >=20 > Signed-off-by: Aapo Vienamo > --- > drivers/mmc/host/sdhci-tegra.c | 32 +++++++++++++++++++++++++++++--- > 1 file changed, 29 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegr= a.c [...] > @@ -545,20 +555,33 @@ static unsigned int tegra_sdhci_get_max_clock(struc= t sdhci_host *host) > return clk_round_rate(pltfm_host->clk, UINT_MAX); > } > =20 > +static void tegra_sdhci_set_dqs_trim(struct sdhci_host *host, u8 val) > +{ > + u32 reg; > + > + reg =3D sdhci_readl(host, SDHCI_TEGRA_VENDOR_CAP_OVERRIDES); > + reg &=3D ~SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_MASK; > + reg |=3D val<