Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)

Steven Rostedt
2018-08-14T00:05:26Z

On Mon, 13 Aug 2018 20:01:41 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Fri, 10 Aug 2018 23:14:01 -0700
> Song Liu <liu.song.a23@gmail.com> wrote:
>
> > On Fri, Aug 10, 2018 at 12:58 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > > On Thu, 9 Aug 2018 16:38:28 +0200
> > > Oleg Nesterov <oleg@redhat.com> wrote:
> > >
> > >> I need to read this (hopefully final) version carefully. I'll try to do
> > >> this before next Monday.
> > >>
> > >
> > > Monday may be the opening of the merge window (more likely Sunday). Do
> > > you think this is good enough for pushing it in this late in the game,
> > > or do you think we should wait another cycle?
> > >
> > > -- Steve
> >
> > We (Facebook) have use cases in production that would benefit from this work, so
> > I would rather see this gets in sooner than later. After a brief
> > review (I will more
> > careful review before Monday), I think this set is not likely to break
> > existing uprobes
> > (those w/o ref_ctr). Therefore, I think it is safe to put it in this cycle.
> >
>
> It's still going under review, and the merge window is now open. I'd
> prefer that this waits till the next merge window.
>
>

But this said, patch 1&2 look simple enough to include this merge
window. I'll pull them in and start testing.

-- Steve