From: Himanshu Jha <himanshujha199640@gmail.com>
To: Sumit Kumar <sumit686215@gmail.com>
Cc: Rob Springer <rspringer@google.com>,
John Joseph <jnjoseph@google.com>,
Ben Chan <benchan@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gasket: remove null ptr check before kfree
Date: Sun, 12 Aug 2018 17:33:31 +0530 [thread overview]
Message-ID: <20180812120331.GA5913@himanshu-Vostro-3559> (raw)
In-Reply-To: <20180812065837.GA20728@ubuntu>
On Sun, Aug 12, 2018 at 12:28:37PM +0530, Sumit Kumar wrote:
> Remove null ptr check before kfree because kfree is null ptr safe.
> Issue found by checkpatch.
>
> Signed-off-by: Sumit Kumar <sumit686215@example.com>
Hmm. Victim of copy-paste I guess.
No worries. Next time just use:
$ git commit -s
To understand what -s flag does, refer `man git commit`.
> ---
Now, this where you should have put versions just below the '---':
v2:
- corrected email address.
And yes, the subject should be:
"Subject: [PATCH v2] staging: gasket: remove null ptr check before kfree"
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
Hope that helps!
--
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology
next prev parent reply other threads:[~2018-08-12 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 6:58 [PATCH] staging: gasket: remove null ptr check before kfree Sumit Kumar
2018-08-12 12:03 ` Himanshu Jha [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-12 7:08 Sumit Kumar
[not found] <20180810203018.GA130845@ubuntu>
[not found] ` <20180811132704.GA1216@kroah.com>
[not found] ` <CACFOd6VMUgpd5mfpm0ByxKkW64_yoJRn8n58mENhJkeWEF_A=Q@mail.gmail.com>
2018-08-12 6:39 ` Greg Kroah-Hartman
2018-08-11 21:47 Sumit Kumar
2018-08-12 6:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180812120331.GA5913@himanshu-Vostro-3559 \
--to=himanshujha199640@gmail.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=sumit686215@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox