Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

Gao Xiang
2018-08-13T13:42:16Z

Hi Dan,

On 2018/8/13 20:25, Dan Carpenter wrote:
> On Mon, Aug 13, 2018 at 08:17:27PM +0800, Gao Xiang wrote:
>>> /* we assume that ofs is aligned with 4 bytes */
>>> it->ofs = EROFS_XATTR_ALIGN(it->ofs);
>>> return err;
>>>
> This might be cleaner if we wrote:
>
> return (err < 0) ? error : 0;
>
> The callers all treate zero and one the same so there isn't any reason
> to propogate the 1 back.
>

Thanks, I will recheck all callers and fix as you suggested.
But it is better to fix them in an independent patch. :) I will send a new patch later.

Thanks,
Gao Xiang

> regards,
> dan carpenter
>