From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/memory-model: Fix a couple of typos
Date: Sun, 12 Aug 2018 16:36:08 -0700 [thread overview]
Message-ID: <20180812233608.GK24813@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180812052928.32354-1-sj38.park@gmail.com>
On Sun, Aug 12, 2018 at 02:29:28PM +0900, SeongJae Park wrote:
> This commit fixes a couple of typos in README and recipies.txt.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Good catch on the first "The the"! (Why say it once when you can say
it twice?)
On the second, the quoted output doesn't have a comma, so the quote of
that output also needs not to have a comma. So I applied the first
patch and left out the second. But please let me know if I am missing
something.
Thanx, Paul
> ---
> tools/memory-model/Documentation/recipes.txt | 2 +-
> tools/memory-model/README | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/memory-model/Documentation/recipes.txt b/tools/memory-model/Documentation/recipes.txt
> index a40802fa1099..29df496c1c77 100644
> --- a/tools/memory-model/Documentation/recipes.txt
> +++ b/tools/memory-model/Documentation/recipes.txt
> @@ -311,7 +311,7 @@ The smp_wmb() macro orders prior stores against later stores, and the
> smp_rmb() macro orders prior loads against later loads. Therefore, if
> the final value of r0 is 1, the final value of r1 must also be 1.
>
> -The the xlog_state_switch_iclogs() function in fs/xfs/xfs_log.c contains
> +The xlog_state_switch_iclogs() function in fs/xfs/xfs_log.c contains
> the following write-side code fragment:
>
> log->l_curr_block -= log->l_logBBsize;
> diff --git a/tools/memory-model/README b/tools/memory-model/README
> index ee987ce20aae..73313faf4036 100644
> --- a/tools/memory-model/README
> +++ b/tools/memory-model/README
> @@ -89,7 +89,7 @@ The corresponding output includes:
> Observation SB+fencembonceonces Never 0 2000000
> Time SB+fencembonceonces 0.16
>
> -The "Positive: 0 Negative: 2000000" and the "Never 0 2000000" indicate
> +The "Positive: 0, Negative: 2000000" and the "Never 0 2000000" indicate
> that during two million trials, the state specified in this litmus
> test's "exists" clause was not reached.
>
> --
> 2.13.0
>
prev parent reply other threads:[~2018-08-12 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 5:29 [PATCH] tools/memory-model: Fix a couple of typos SeongJae Park
2018-08-12 23:36 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180812233608.GK24813@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox