From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2682C4646D for ; Mon, 13 Aug 2018 18:59:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7489A21798 for ; Mon, 13 Aug 2018 18:59:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7489A21798 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730548AbeHMVmr (ORCPT ); Mon, 13 Aug 2018 17:42:47 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41518 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730060AbeHMVmr (ORCPT ); Mon, 13 Aug 2018 17:42:47 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 129FB4001868; Mon, 13 Aug 2018 18:59:18 +0000 (UTC) Received: from sandy.ghostprotocols.net (ovpn-112-5.gru2.redhat.com [10.97.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 06B852156712; Mon, 13 Aug 2018 18:59:16 +0000 (UTC) Received: by sandy.ghostprotocols.net (Postfix, from userid 1000) id D186C147; Mon, 13 Aug 2018 15:59:12 -0300 (BRT) Date: Mon, 13 Aug 2018 15:59:12 -0300 From: Arnaldo Carvalho de Melo To: Kim Phillips Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Dongjiu Geng , Adrian Hunter , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: arm-spe: Fix uninitialized record error variable Message-ID: <20180813185912.GB2146@redhat.com> References: <20180810174512.52900813e57cbccf18ce99a2@arm.com> <20180813185511.GA2146@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180813185511.GA2146@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 13 Aug 2018 18:59:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 13 Aug 2018 18:59:18 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'acme@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Aug 13, 2018 at 03:55:11PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Aug 10, 2018 at 05:45:12PM -0500, Kim Phillips escreveu: > > The auxtrace init variable 'err' was not being initialized, leading > > perf to abort early in an SPE record command when there was no explicit > > error, rather only based whatever memory contents were on the stack. > > Initialize it explicitly on getting an SPE successfully, the same way > > cs-etm does. > > > > Signed-off-by: Kim Phillips > > --- > > Hi Arnaldo, please apply to perf/urgent / stable series if at all > > possible. Thank you. > > In such cases the best thing is to have a "Fixes: ..." so that this gets > automatically picked by the stabe trees, I'll try to find out what was > the patch that introduced this problem. This one was easy, there is just one cset for this file prior to this fix, so: Fixes: ffd3d18c20b8 ("perf tools: Add ARM Statistical Profiling Extensions (SPE) support") - Arnaldo