From: Lee Jones <lee.jones@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: sm501: Set coherent_dma_mask when creating subdevices
Date: Thu, 16 Aug 2018 10:07:01 +0100 [thread overview]
Message-ID: <20180816090701.GE10054@dell> (raw)
In-Reply-To: <1533355191-26512-1-git-send-email-linux@roeck-us.net>
On Fri, 03 Aug 2018, Guenter Roeck wrote:
> Instantiating the sm501 OHCI subdevice results in a kernel warning.
>
> sm501-usb sm501-usb: SM501 OHCI
> sm501-usb sm501-usb: new USB bus registered, assigned bus number 1
> WARNING: CPU: 0 PID: 1 at ./include/linux/dma-mapping.h:516
> ohci_init+0x194/0x2d8
> Modules linked in:
>
> CPU: 0 PID: 1 Comm: swapper Tainted: G W
> 4.18.0-rc7-00178-g0b5b1f9a78b5 #1
> PC is at ohci_init+0x194/0x2d8
> PR is at ohci_init+0x168/0x2d8
> PC : 8c27844c SP : 8f81dd94 SR : 40008001
> TEA : 29613060
> R0 : 00000000 R1 : 00000000 R2 : 00000000 R3 : 00000202
> R4 : 8fa98b88 R5 : 8c277e68 R6 : 00000000 R7 : 00000000
> R8 : 8f965814 R9 : 8c388100 R10 : 8fa98800 R11 : 8fa98928
> R12 : 8c48302c R13 : 8fa98920 R14 : 8c48302c
> MACH: 00000096 MACL: 0000017c GBR : 00000000 PR : 8c278420
>
> Call trace:
> [<(ptrval)>] usb_add_hcd+0x1e8/0x6ec
> [<(ptrval)>] _dev_info+0x0/0x54
> [<(ptrval)>] arch_local_save_flags+0x0/0x8
> [<(ptrval)>] arch_local_irq_restore+0x0/0x24
> [<(ptrval)>] ohci_hcd_sm501_drv_probe+0x114/0x2d8
> ...
>
> Initialize coherent_dma_mask when creating SM501 subdevices to fix
> the problem.
>
> Fixes: b6d6454fdb66f ("mfd: SM501 core driver")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/mfd/sm501.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2018-08-16 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 3:59 [PATCH] mfd: sm501: Set coherent_dma_mask when creating subdevices Guenter Roeck
2018-08-16 9:07 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816090701.GE10054@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox