From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A417CC4321D for ; Thu, 16 Aug 2018 13:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51CCA2124D for ; Thu, 16 Aug 2018 13:53:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51CCA2124D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389681AbeHPQvv (ORCPT ); Thu, 16 Aug 2018 12:51:51 -0400 Received: from foss.arm.com ([217.140.101.70]:36998 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388977AbeHPQvv (ORCPT ); Thu, 16 Aug 2018 12:51:51 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 27C1680D; Thu, 16 Aug 2018 06:53:06 -0700 (PDT) Received: from e110439-lin (e110439-lin.Emea.Arm.com [10.4.12.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7C4693F5D0; Thu, 16 Aug 2018 06:53:03 -0700 (PDT) Date: Thu, 16 Aug 2018 14:53:00 +0100 From: Patrick Bellasi To: Dietmar Eggemann Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Viresh Kumar , Vincent Guittot , Paul Turner , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan Subject: Re: [PATCH v3 05/14] sched/cpufreq: uclamp: add utilization clamping for FAIR tasks Message-ID: <20180816135300.GC2960@e110439-lin> References: <20180806163946.28380-1-patrick.bellasi@arm.com> <20180806163946.28380-6-patrick.bellasi@arm.com> <012b7e15-888c-a200-c34b-4fac0f8ab8b9@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <012b7e15-888c-a200-c34b-4fac0f8ab8b9@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-Aug 17:30, Dietmar Eggemann wrote: > On 08/06/2018 06:39 PM, Patrick Bellasi wrote: > > [...] > > >+#else /* CONFIG_UCLAMP_TASK */ > >+static inline unsigned int uclamp_value(unsigned int cpu, int clamp_id) > >+{ > >+ return uclamp_none(clamp_id); > >+} > > Looks like that uclamp_value() is not used outside CONFIG_UCLAMP_TASK areas. Yes, you right... I use it on some debug patches I'm tracking on top of the series... but I can defenitivel drop it in v4. Cheers Patrick -- #include Patrick Bellasi