From: Andrey Vagin <avagin@virtuozzo.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [linux-next] Kernel panic while tetsing criu
Date: Thu, 16 Aug 2018 10:21:55 -0700 [thread overview]
Message-ID: <20180816172154.GA28188@outlook.office365.com> (raw)
In-Reply-To: <20180816151835.GW10406@uranus.lan>
On Thu, Aug 16, 2018 at 06:18:35PM +0300, Cyrill Gorcunov wrote:
> On Thu, Aug 16, 2018 at 09:51:36AM -0500, Eric W. Biederman wrote:
> ...
> >
> > That patch is incorrect as it misses the rcu_read_unlock.
> > >
> > > p.s. Andrew noticed the problem and asked me to notify,
> > > also he has been testing this oneliner patch. I'm out
> > > of sources at the moment but I think Andrew will help
> > > to test if needed.
> >
> > I noticed a similar report from syzbot yesterday and I applied the patch
> > below. Can you verify it fixes your issue?
>
> I'm quite sure it will help, since the patch is almost doing the same
> as Andrew's fast fix, which checks for @p being nil. But to be sure
> lets wait Andrew to verify.
It fixes the issue.
Thanks,
Andrei
prev parent reply other threads:[~2018-08-16 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 9:24 [linux-next] Kernel panic while tetsing criu Cyrill Gorcunov
2018-08-16 14:51 ` Eric W. Biederman
2018-08-16 15:18 ` Cyrill Gorcunov
2018-08-16 17:21 ` Andrey Vagin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816172154.GA28188@outlook.office365.com \
--to=avagin@virtuozzo.com \
--cc=ebiederm@xmission.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox