From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Jiri Kosina <jikos@kernel.org>,
x86@kernel.org, Christoph Hellwig <hch@lst.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: apm: mark proc_apm_show as __maybe_unused
Date: Fri, 17 Aug 2018 08:43:44 +0200 [thread overview]
Message-ID: <20180817064344.GC10811@lst.de> (raw)
In-Reply-To: <20180814091904.2186262-1-arnd@arndb.de>
On Tue, Aug 14, 2018 at 11:18:45AM +0200, Arnd Bergmann wrote:
> A new build error appeared with CONFIG_PROC_FS disabled:
>
> arch/x86/kernel/apm_32.c:1643:12: error: 'proc_apm_show' defined but not used [-Werror=unused-function]
>
> This marks the function as __maybe_unused to let the compiler drop
> it silently.
>
> Fixes: 3f3942aca6da ("proc: introduce proc_create_single{,_data}")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I have to admit I actually prefer ifdefs over magic __maybe_unused
annotations. But otherwise this looks correct to me, same for the
other patch.
next prev parent reply other threads:[~2018-08-17 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 9:18 [PATCH 1/2] x86: apm: mark proc_apm_show as __maybe_unused Arnd Bergmann
2018-08-14 9:18 ` [PATCH 2/2] ARM: rpc: mark ecard_devices_proc_show " Arnd Bergmann
2018-08-17 6:43 ` Christoph Hellwig [this message]
2018-08-20 15:40 ` [PATCH 1/2] x86: apm: mark proc_apm_show " Thomas Gleixner
2018-08-20 16:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817064344.GC10811@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).