From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Yixun Lan <yixun.lan@amlogic.com>
Cc: <linux-mtd@lists.infradead.org>, Rob Herring <robh@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Liang Yang <liang.yang@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller
Date: Fri, 17 Aug 2018 10:46:57 +0200 [thread overview]
Message-ID: <20180817104657.7a1da2c4@bbrezillon> (raw)
In-Reply-To: <20180719094612.5833-3-yixun.lan@amlogic.com>
Hi Yixun,
I know I said I would finish reviewing the driver, but I didn't have
time to do it, so feel free to send a new version addressing the
comments I already made.
On Thu, 19 Jul 2018 17:46:12 +0800
Yixun Lan <yixun.lan@amlogic.com> wrote:
> +static void meson_nfc_select_chip(struct mtd_info *mtd, int chip)
> +{
> + struct nand_chip *nand = mtd_to_nand(mtd);
> + struct meson_nfc_nand_chip *meson_chip = to_meson_nand(nand);
> + struct meson_nfc *nfc = nand_get_controller_data(nand);
> +
> + if (chip < 0 || chip > MAX_CE_NUM)
^ chip > meson_chip->nsels)
> + return;
> +
> + nfc->param.chip_select = meson_chip->sels[chip] ? NAND_CE1 : NAND_CE0;
> + nfc->param.rb_select = nfc->param.chip_select;
> +}
> +
Regards,
Boris
prev parent reply other threads:[~2018-08-17 8:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 9:46 [RFC PATCH v2 0/2] mtd: rawnand: meson: add Amlogic NAND driver support Yixun Lan
2018-07-19 9:46 ` [RFC PATCH v2 1/2] dt-bindings: nand: meson: add Amlogic NAND controller driver Yixun Lan
2018-07-19 9:57 ` Boris Brezillon
2018-07-19 10:07 ` Yixun Lan
2018-07-19 9:46 ` [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller Yixun Lan
2018-08-01 21:50 ` Boris Brezillon
2018-08-02 14:04 ` Yixun Lan
2018-08-17 13:03 ` Liang Yang
2018-08-17 13:56 ` Boris Brezillon
2018-08-21 3:33 ` Liang Yang
2018-08-22 14:08 ` Liang Yang
2018-08-24 12:48 ` Boris Brezillon
2018-08-28 13:21 ` Liang Yang
2018-08-28 13:26 ` Boris Brezillon
2018-08-29 10:08 ` Liang Yang
2018-08-29 10:29 ` Liang Yang
2018-08-29 10:31 ` Boris Brezillon
2018-08-17 8:46 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817104657.7a1da2c4@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=carlo@caione.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).