From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 836E8C4321D for ; Fri, 17 Aug 2018 11:49:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34384208EB for ; Fri, 17 Aug 2018 11:49:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34384208EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727105AbeHQOwN (ORCPT ); Fri, 17 Aug 2018 10:52:13 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40818 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726134AbeHQOwN (ORCPT ); Fri, 17 Aug 2018 10:52:13 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 969E04059FF8; Fri, 17 Aug 2018 11:49:03 +0000 (UTC) Received: from krava (unknown [10.43.17.209]) by smtp.corp.redhat.com (Postfix) with SMTP id 9CC6B101043A; Fri, 17 Aug 2018 11:48:58 +0000 (UTC) Date: Fri, 17 Aug 2018 13:48:58 +0200 From: Jiri Olsa To: Ingo Molnar Cc: Arnaldo Carvalho de Melo , lkml , Jiri Olsa , Namhyung Kim , David Ahern , Alexander Shishkin , Peter Zijlstra , Milind Chabbi , Oleg Nesterov , Frederic Weisbecker Subject: Re: [PATCHv3 0/5] perf/hw_breakpoint: Fix breakpoint modify Message-ID: <20180817114858.GB24121@krava> References: <20180810104730.3293-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180810104730.3293-1-jolsa@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 17 Aug 2018 11:49:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 17 Aug 2018 11:49:03 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jolsa@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 10, 2018 at 12:47:25PM +0200, Jiri Olsa wrote: > hi, > Milind reported that modify_user_hw_breakpoint wouldn't > allow the breakpoint changing if the new attr had 'disabled' > set to true. > > I found a case where it actualy prevents ptrace user interface > to change the breakpoint. It's described in patch 1 as perf test, > patch 2 is the breakpoint code fix. > > I ran strace tests, nothing (new) broken there.. > > v3 changes: > - added Oleg's ack for patch 3 > - new patches 4,5 based on Oleg's suggestions > replacing the v2 fallback approach by enabling > the event directly after failed modification Ingo, Arnaldo, would you please pick up those, or should I pushed them through somebody else? thanks, jirka > > v2 changes: > - added Oleg's ack for patch 2 > - added new changes based on Oleg's questions > plus new test code > > thanks, > jirka > > --- > Jiri Olsa (5): > perf tests: Add breakpoint modify tests > perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set > perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0 > perf/hw_breakpoint: Enable breakpoint in modify_user_hw_breakpoint > perf/hw_breakpoint: Simplify breakpoint enable in perf_event_modify_breakpoint > > kernel/events/core.c | 11 ++----- > kernel/events/hw_breakpoint.c | 13 ++++---- > tools/perf/arch/x86/include/arch-tests.h | 1 + > tools/perf/arch/x86/tests/Build | 1 + > tools/perf/arch/x86/tests/arch-tests.c | 6 ++++ > tools/perf/arch/x86/tests/bp-modify.c | 213 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 230 insertions(+), 15 deletions(-) > create mode 100644 tools/perf/arch/x86/tests/bp-modify.c