The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bhaskar Singh <bhaskar.kernel@gmail.com>
Cc: mark.rutland@arm.com, linux-kernel@vger.kernel.org, mingo@kernel.org
Subject: Re: [PATCH] kernel: Add spaces around '=' operator
Date: Fri, 17 Aug 2018 18:19:31 +0200	[thread overview]
Message-ID: <20180817161931.GC24945@kroah.com> (raw)
In-Reply-To: <20180817132348.GA5326@Gentoo-PC>

On Fri, Aug 17, 2018 at 06:53:48PM +0530, Bhaskar Singh wrote:
> This patch fixes the checkpatch.pl ERROR:
> 
> ERROR: spaces required around that '==' (ctx:VxV)
> 
> Signed-off-by: Bhaskar Singh <bhaskar.kernel@gmail.com>
> ---
>  kernel/acct.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/acct.c b/kernel/acct.c
> index addf7732fb56..6dc0a55b575c 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -449,7 +449,7 @@ static void fill_ac(acct_t *ac)
>  #endif
>  	do_div(elapsed, AHZ);
>  	ac->ac_btime = get_seconds() - elapsed;
> -#if ACCT_VERSION==2
> +#if ACCT_VERSION == 2

checkpatch is a guide, not a fast rule, and might not matter here.

Please stick to checkpatch fixes in drivers/staging/ only, not any other
part of the kernel unless you know the maintainer accepts such patches.

thanks,

greg k-h

      reply	other threads:[~2018-08-17 16:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17 13:23 [PATCH] kernel: Add spaces around '=' operator Bhaskar Singh
2018-08-17 16:19 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180817161931.GC24945@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhaskar.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox