* [PATCH v3 1/3] soc: imx: gpc: fix PDN delay
@ 2018-07-24 9:46 Sven Schmitt
2018-07-24 11:51 ` Leonard Crestez
2018-08-21 15:14 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Sven Schmitt @ 2018-07-24 9:46 UTC (permalink / raw)
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: etnaviv@lists.freedesktop.org, l.stach@pengutronix.de
imx6_pm_domain_power_off() reads iso and iso2sw from GPC_PGC_PUPSCR_OFFS
which stores the power up delays.
So use GPC_PGC_PDNSCR_OFFS for the correct delays.
Signed-off-by: Sven Schmitt <sven.schmitt@mixed-mode.de>
---
drivers/soc/imx/gpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
index 0097a939487f..5126185e68c6 100644
--- a/drivers/soc/imx/gpc.c
+++ b/drivers/soc/imx/gpc.c
@@ -73,7 +73,7 @@ static int imx6_pm_domain_power_off(struct generic_pm_domain *genpd)
return -EBUSY;
/* Read ISO and ISO2SW power down delays */
- regmap_read(pd->regmap, pd->reg_offs + GPC_PGC_PUPSCR_OFFS, &val);
+ regmap_read(pd->regmap, pd->reg_offs + GPC_PGC_PDNSCR_OFFS, &val);
iso = val & 0x3f;
iso2sw = (val >> 8) & 0x3f;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/3] soc: imx: gpc: fix PDN delay
2018-07-24 9:46 [PATCH v3 1/3] soc: imx: gpc: fix PDN delay Sven Schmitt
@ 2018-07-24 11:51 ` Leonard Crestez
2018-08-21 15:14 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Leonard Crestez @ 2018-07-24 11:51 UTC (permalink / raw)
To: Sven.Schmitt@mixed-mode.de, shawnguo@kernel.org
Cc: l.stach@pengutronix.de, s.hauer@pengutronix.de,
linux-arm-kernel@lists.infradead.org, Fabio Estevam,
kernel@pengutronix.de, dl-linux-imx, linux-kernel@vger.kernel.org
On Tue, 2018-07-24 at 09:46 +0000, Sven Schmitt wrote:
> imx6_pm_domain_power_off() reads iso and iso2sw from
> GPC_PGC_PUPSCR_OFFS
> which stores the power up delays.
> So use GPC_PGC_PDNSCR_OFFS for the correct delays.
>
> Signed-off-by: Sven Schmitt <sven.schmitt@mixed-mode.de>
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -73,7 +73,7 @@ static int imx6_pm_domain_power_off(struct generic_pm_domain *genpd)
> return -EBUSY;
>
> /* Read ISO and ISO2SW power down delays */
> - regmap_read(pd->regmap, pd->reg_offs + GPC_PGC_PUPSCR_OFFS, &val);
> + regmap_read(pd->regmap, pd->reg_offs + GPC_PGC_PDNSCR_OFFS, &val);
> iso = val & 0x3f;
> iso2sw = (val >> 8) & 0x3f;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/3] soc: imx: gpc: fix PDN delay
2018-07-24 9:46 [PATCH v3 1/3] soc: imx: gpc: fix PDN delay Sven Schmitt
2018-07-24 11:51 ` Leonard Crestez
@ 2018-08-21 15:14 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2018-08-21 15:14 UTC (permalink / raw)
To: Sven Schmitt
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
fabio.estevam@nxp.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org,
l.stach@pengutronix.de
On Tue, Jul 24, 2018 at 09:46:03AM +0000, Sven Schmitt wrote:
> imx6_pm_domain_power_off() reads iso and iso2sw from GPC_PGC_PUPSCR_OFFS
> which stores the power up delays.
> So use GPC_PGC_PDNSCR_OFFS for the correct delays.
>
> Signed-off-by: Sven Schmitt <sven.schmitt@mixed-mode.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-21 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-24 9:46 [PATCH v3 1/3] soc: imx: gpc: fix PDN delay Sven Schmitt
2018-07-24 11:51 ` Leonard Crestez
2018-08-21 15:14 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox