public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Eduardo Valentin <eduval@amazon.com>
Cc: Andi Kleen <ak@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Kan Liang <kan.liang@linux.intel.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Jia Zhang <qianyue.zj@alibaba-inc.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] perf/x86/intel: make error messages less confusing
Date: Wed, 22 Aug 2018 10:45:58 +0200	[thread overview]
Message-ID: <20180822084558.GS24124@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180821230522.GA10816@u40b0340c692b58f6553c.ant.amazon.com>

On Tue, Aug 21, 2018 at 04:05:22PM -0700, Eduardo Valentin wrote:
> On Tue, Aug 21, 2018 at 03:09:37PM -0700, Andi Kleen wrote:
> > On Tue, Aug 21, 2018 at 02:15:28PM -0700, Eduardo Valentin wrote:

> > > [ 0.100114] Performance Events: unsupported p6 CPU model 85 no PMU driver, software events only.

> > Maybe it is confusing (why exactly?), but it doesn't seem to me that your
> > new message is any better.
> 
> Yeah, the part that says "unsupported CPU" is the confusing part,
> I get people thinking that the specific reported CPU model is not
> supported by the kernel :-)

It is prefixed by: "Performance Events:", what is the problem?

      parent reply	other threads:[~2018-08-22  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21 21:15 [PATCH 1/1] perf/x86/intel: make error messages less confusing Eduardo Valentin
2018-08-21 22:09 ` Andi Kleen
2018-08-21 23:05   ` Eduardo Valentin
2018-08-21 23:59     ` Andi Kleen
2018-08-22 20:57       ` Eduardo Valentin
2018-08-22  8:45     ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822084558.GS24124@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=eduval@amazon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=qianyue.zj@alibaba-inc.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox