From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
NeilBrown <neil@brown.name>, "Joe Perches" <joe@perches.com>,
"Christian Lütke-Stetzkamp" <christian@lkamp.de>,
"John Crispin" <blogic@openwrt.org>
Subject: Re: [PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages
Date: Wed, 22 Aug 2018 12:13:42 +0300 [thread overview]
Message-ID: <20180822091342.kngqyebexaboo25g@mwanda> (raw)
In-Reply-To: <52fcb157ea0de00e7c08d90ebd8a5c1db3c33bae.1534923403.git.nishadkamdar@gmail.com>
On Wed, Aug 22, 2018 at 02:13:07PM +0530, Nishad Kamdar wrote:
> diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
> index 04d23cc7cd4a..6b2c72fc61f2 100644
> --- a/drivers/staging/mt7621-mmc/sd.c
> +++ b/drivers/staging/mt7621-mmc/sd.c
> @@ -466,7 +466,8 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
> //u8 clksrc = hw->clk_src;
>
> if (!hz) { // set mmc system clock to 0 ?
> - //ERR_MSG("set mclk to 0!!!");
> + //dev_err(mmc_dev(host->mmc), "%d -> set mclk to 0!!!\n",
> + // host->id);
Just delete commented out code.
> msdc_reset_hw(host);
> return;
> }
regards,
dan carpenter
next prev parent reply other threads:[~2018-08-22 9:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 8:33 [PATCH v4 0/4] Fix debug macros and their usages Nishad Kamdar
2018-08-22 8:34 ` [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG Nishad Kamdar
2018-08-22 9:09 ` Dan Carpenter
2018-08-22 11:10 ` Nishad Kamdar
2018-08-22 11:26 ` Greg Kroah-Hartman
2018-08-23 17:13 ` Nishad Kamdar
2018-08-22 11:38 ` Dan Carpenter
2018-08-23 17:19 ` Nishad Kamdar
2018-08-22 8:43 ` [PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages Nishad Kamdar
2018-08-22 9:13 ` Dan Carpenter [this message]
2018-08-22 11:16 ` Nishad Kamdar
2018-08-23 17:15 ` Nishad Kamdar
2018-08-22 8:45 ` [PATCH v4 3/4] staging: mt7621-mmc: Remove macro INIT_MSG " Nishad Kamdar
2018-08-22 8:47 ` [PATCH v4 4/4] staging: mt7621-mmc: Fix debug macro IRQ_MSG " Nishad Kamdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822091342.kngqyebexaboo25g@mwanda \
--to=dan.carpenter@oracle.com \
--cc=blogic@openwrt.org \
--cc=christian@lkamp.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
--cc=nishadkamdar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox