v4.19-rc0: compile problem in ./include/media/cec.h:82:24:

v4.19-rc0: compile problem in ./include/media/cec.h:82:24:

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

Hi!

I'm getting this in -rc0:

  CC      drivers/gpu/drm/ttm/ttm_tt.o
  In file included from ./include/media/cec-notifier.h:13:0,
                   from drivers/gpu/drm/i915/intel_drv.h:42,
		                    from
  drivers/gpu/drm/i915/i915_trace.h:11,
                   from drivers/gpu/drm/i915/i915_drv.h:2667,
		                    from
  drivers/gpu/drm/i915/i915_irq.c:36:
  ./include/media/cec.h:82:24: error: ‘CEC_EVENT_PIN_5V_HIGH’
  undeclared here (not in a function)
   #define CEC_NUM_EVENTS CEC_EVENT_PIN_5V_HIGH
                           ^
			   ./include/media/cec.h:94:26: note: in
  expansion of macro ‘CEC_NUM_EVENTS’
    struct list_head events[CEC_NUM_EVENTS]; /* queued events */
                              ^
 CC      drivers/input/serio/serport.o

Reverting 4786b0d6f3ca6da8db02b0a58cd2b785cb0b80ab seems to help.

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: v4.19-rc0: compile problem in ./include/media/cec.h:82:24:

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]

Hi!

> I'm getting this in -rc0:
> 
>   CC      drivers/gpu/drm/ttm/ttm_tt.o
>   In file included from ./include/media/cec-notifier.h:13:0,
>                    from drivers/gpu/drm/i915/intel_drv.h:42,
> 		                    from
>   drivers/gpu/drm/i915/i915_trace.h:11,
>                    from drivers/gpu/drm/i915/i915_drv.h:2667,
> 		                    from
>   drivers/gpu/drm/i915/i915_irq.c:36:
>   ./include/media/cec.h:82:24: error: ‘CEC_EVENT_PIN_5V_HIGH’
>   undeclared here (not in a function)
>    #define CEC_NUM_EVENTS CEC_EVENT_PIN_5V_HIGH
>                            ^
> 			   ./include/media/cec.h:94:26: note: in
>   expansion of macro ‘CEC_NUM_EVENTS’
>     struct list_head events[CEC_NUM_EVENTS]; /* queued events */
>                               ^
>  CC      drivers/input/serio/serport.o
> 
> Reverting 4786b0d6f3ca6da8db02b0a58cd2b785cb0b80ab seems to help.

No, sorry, it does not. I was confused. Let me try

HDMI CEC support (MEDIA_CEC_SUPPORT) [N/y/?] (NEW) y

No change.

Let me add

#include <uapi/linux/cec.h>

into include/media/cec.h... no.

Any ideas?
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: v4.19-rc0: compile problem in ./include/media/cec.h:82:24:

[Hans Verkuil]

On 22/08/18 23:12, Pavel Machek wrote:
> Hi!
> 
>> I'm getting this in -rc0:
>>
>>   CC      drivers/gpu/drm/ttm/ttm_tt.o
>>   In file included from ./include/media/cec-notifier.h:13:0,
>>                    from drivers/gpu/drm/i915/intel_drv.h:42,
>> 		                    from
>>   drivers/gpu/drm/i915/i915_trace.h:11,
>>                    from drivers/gpu/drm/i915/i915_drv.h:2667,
>> 		                    from
>>   drivers/gpu/drm/i915/i915_irq.c:36:
>>   ./include/media/cec.h:82:24: error: ‘CEC_EVENT_PIN_5V_HIGH’
>>   undeclared here (not in a function)
>>    #define CEC_NUM_EVENTS CEC_EVENT_PIN_5V_HIGH
>>                            ^
>> 			   ./include/media/cec.h:94:26: note: in
>>   expansion of macro ‘CEC_NUM_EVENTS’
>>     struct list_head events[CEC_NUM_EVENTS]; /* queued events */
>>                               ^
>>  CC      drivers/input/serio/serport.o
>>
>> Reverting 4786b0d6f3ca6da8db02b0a58cd2b785cb0b80ab seems to help.
> 
> No, sorry, it does not. I was confused. Let me try
> 
> HDMI CEC support (MEDIA_CEC_SUPPORT) [N/y/?] (NEW) y
> 
> No change.
> 
> Let me add
> 
> #include <uapi/linux/cec.h>
> 
> into include/media/cec.h... no.
> 
> Any ideas?
> 								Pavel
> 

media/cec.h includes linux/cec-funcs.h which includes linux/cec.h. This last
header defines CEC_EVENT_PIN_5V_HIGH.

If it doesn't for some reason, then you have some broken tree since it definitely
is there if I look at the current mainline kernel.

Regards,

	Hans