From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76232C4321D for ; Thu, 23 Aug 2018 06:13:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B07220936 for ; Thu, 23 Aug 2018 06:13:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B07220936 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726224AbeHWJlA (ORCPT ); Thu, 23 Aug 2018 05:41:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37596 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbeHWJlA (ORCPT ); Thu, 23 Aug 2018 05:41:00 -0400 Received: from localhost (5355525A.cm-6-6b.dynamic.ziggo.nl [83.85.82.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 6543D49B; Thu, 23 Aug 2018 06:12:56 +0000 (UTC) Date: Thu, 23 Aug 2018 08:12:53 +0200 From: Greg Kroah-Hartman To: Roland Dreier Cc: LKML , stable@vger.kernel.org, ben.hutchings@codethink.co.uk, matt@codeblueprint.co.uk, bp@suse.de, Andrew Morton , Andy Lutomirski , luto@kernel.org, ard.biesheuvel@linaro.org, bp@alien8.de, brgerst@gmail.com, davej@codemonkey.org.uk, dvlasenk@redhat.com, "H. Peter Anvin" , Linus Torvalds , Peter Zijlstra , sai.praneeth.prakhya@intel.com, sds@tycho.nsa.gov, Thomas Gleixner , toshi.kani@hp.com, linux-efi@vger.kernel.org, Ingo Molnar , Yazen.Ghannam@amd.com Subject: Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" Message-ID: <20180823061253.GA8803@kroah.com> References: <20171215092305.994559179@linuxfoundation.org> <20171215092311.347628971@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 22, 2018 at 05:48:32PM -0700, Roland Dreier wrote: > On Fri, Dec 15, 2017 at 2:20 AM Greg Kroah-Hartman > wrote: > > This reverts commit 87e2bd898d3a79a8c609f183180adac47879a2a4 which is > > commit edc3b9129cecd0f0857112136f5b8b1bc1d45918 upstream. > > > > Turns there was too many other issues with this patch to make it viable > > for the stable tree. > > This was sort of a long time ago, but does anyone remember why this > needed to be reverted from 4.4? I tried to dig through my old emails, but could not find anything, sorry. > The reason I ask is that without this, commit 02ff2769edbc / > "x86/mm/pat: Make set_memory_np() L1TF safe" in 4.4.148 is broken. > That patch has > > - set_pud(pud, __pud(cpa->pfn | _PAGE_PSE | > - massage_pgprot(pud_pgprot))); > + set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, > + canon_pgprot(pud_pgprot)))); > > (and similarly for pmds) but pfn_pud() is operating on page frame > numbers and __pud(cpa->pfn... in the old code is operating on physical > addresses. > > This is bad enough that 4.4.148 and all newer 4.4.y crash early in > boot on some EFI systems that I have. Ugh, not good. > For now I am re-applying the "ensure cpa->pfn only contains page frame > numbers" patch, ported on top of 4.4.151. I can try to add it back and see what blows up, want me to attempt that? :) thanks, greg k-h