From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26F3C4321D for ; Thu, 23 Aug 2018 12:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B770E20834 for ; Thu, 23 Aug 2018 12:19:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B770E20834 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731187AbeHWPtD (ORCPT ); Thu, 23 Aug 2018 11:49:03 -0400 Received: from mail.bootlin.com ([62.4.15.54]:40675 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727646AbeHWPtC (ORCPT ); Thu, 23 Aug 2018 11:49:02 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 3B47D207C4; Thu, 23 Aug 2018 14:19:32 +0200 (CEST) Received: from localhost (242.171.71.37.rev.sfr.net [37.71.171.242]) by mail.bootlin.com (Postfix) with ESMTPSA id 04165207B4; Thu, 23 Aug 2018 14:19:22 +0200 (CEST) Date: Thu, 23 Aug 2018 14:19:21 +0200 From: Alexandre Belloni To: zhong jiang Cc: Claudiu.Beznea@microchip.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: pm: call put_device instead of of_node_put in at91_pm_config_ws Message-ID: <20180823121921.GE21707@piout.net> References: <1534415182-34970-1-git-send-email-zhongjiang@huawei.com> <5B7E9E26.3050209@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B7E9E26.3050209@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/08/2018 19:44:38+0800, zhong jiang wrote: > Hi, alexandre > > Can you pick up the patch? Thanks > We are still in the merge window, this has to wait for v4.19-rc1. > Best wishes, > zhong jiang > > On 2018/8/16 18:26, zhong jiang wrote: > > of_find_device_by_node takes a reference to the struct device when it > > finds a match via get_device. but it fails to put_device in > > at91_pm_config_ws, for_each_matching_node_and_match will get and put > > the node properly, there is no need to call the of_put_node. Therefore, > > just call put_device instead of of_node_put in at91_pm_config_ws. > > > > Fixes: d7484f5c6b3b ("ARM: at91: pm: configure wakeup sources for ULP1 mode") > > Suggested-by: Claudiu Beznea > > Signed-off-by: zhong jiang > > --- > > arch/arm/mach-at91/pm.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > > index 32fae4d..6574f00 100644 > > --- a/arch/arm/mach-at91/pm.c > > +++ b/arch/arm/mach-at91/pm.c > > @@ -143,15 +143,15 @@ static int at91_pm_config_ws(unsigned int pm_mode, bool set) > > > > /* Check if enabled on SHDWC. */ > > if (wsi->shdwc_mr_bit && !(val & wsi->shdwc_mr_bit)) > > - goto put_node; > > + goto put_device; > > > > mode |= wsi->pmc_fsmr_bit; > > if (wsi->set_polarity) > > polarity |= wsi->pmc_fsmr_bit; > > } > > > > -put_node: > > - of_node_put(np); > > +put_device: > > + put_device(&pdev->dev); > > } > > > > if (mode) { > > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com