From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andreas Christoforou <andreaschristofo@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipc/mqueue: Only perform resource calculation if user valid
Date: Fri, 24 Aug 2018 23:29:27 +0100 [thread overview]
Message-ID: <20180824222927.GO6515@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180824215439.GA46785@beast>
On Fri, Aug 24, 2018 at 02:54:39PM -0700, Kees Cook wrote:
> The overflow was real, but the results went unused, so while the flaw
> is harmless, it's noisy for kernel fuzzers, and the fix makes things
> technically more efficient.
yes, yes, yes, yes and no. Compiler is quite capable of noticing
that targets of assignments are unused outside of that if (user), so
any mentioning of "technically more efficient" is somewhat ridiculous...
Just make that something along the lines of "results of these assignments
are only used under if (user). Moreover, in case if info->user is NULL
they might yield an integer overflow, confusing the fuzzers. The odds
of any compiler letting nasal demons fly on that are pretty much nil,
but it's cleaner to move these under if (user) anyway."
prev parent reply other threads:[~2018-08-24 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 21:54 [PATCH] ipc/mqueue: Only perform resource calculation if user valid Kees Cook
2018-08-24 22:29 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824222927.GO6515@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=andreaschristofo@gmail.com \
--cc=arnd@arndb.de \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox