From: Dan Carpenter <dan.carpenter@oracle.com>
To: GuyLuz <guyluz50@gmail.com>
Cc: devel@driverdev.osuosl.org, guyluz11@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: cb_pcidas64 fixed '(' coding style issue
Date: Sat, 25 Aug 2018 10:15:35 +0300 [thread overview]
Message-ID: <20180825071535.igoxbyleusti6wyu@mwanda> (raw)
In-Reply-To: <20180824230701.9029-1-guyluz50@gmail.com>
On Sat, Aug 25, 2018 at 02:07:01AM +0300, GuyLuz wrote:
> From: Guy Luz <guyluz50@gmail.com>
>
> Fixed a Lines should not end with a '(' issue.
>
> Signed-off-by: Guy Luz <guyluz50@gmail.com>
> ---
> drivers/staging/comedi/drivers/cb_pcidas64.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index 63992c0babf7..a85334f53ff9 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -2173,10 +2173,9 @@ static int ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
> * allows
> */
> if (cmd->scan_begin_src == TRIG_TIMER) {
> - err |= comedi_check_trigger_arg_min(
> - &cmd->scan_begin_arg,
> - cmd->convert_arg *
> - cmd->chanlist_len);
> + err |= comedi_check_trigger_arg_min
> + (&cmd->scan_begin_arg, cmd->convert_arg *
> + cmd->chanlist_len);
The original is better than the new version. Please leave it as is.
regards,
dan carpenter
prev parent reply other threads:[~2018-08-25 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 23:07 [PATCH] staging: comedi: cb_pcidas64 fixed '(' coding style issue GuyLuz
2018-08-25 7:15 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180825071535.igoxbyleusti6wyu@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=guyluz11@gmail.com \
--cc=guyluz50@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox