From: Miroslav Lichvar <mlichvar@redhat.com>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: Richard Guy Briggs <rgb@redhat.com>,
Linux-Audit Mailing List <linux-audit@redhat.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH ghak10 v5 2/2] timekeeping/ntp: Audit clock/NTP params adjustments
Date: Mon, 27 Aug 2018 13:45:57 +0200 [thread overview]
Message-ID: <20180827114557.GN27091@localhost> (raw)
In-Reply-To: <CAFqZXNvD_7psR+wM-GTXQ4bwK3w8=t7UnBidojB5XbmbE_K2oA@mail.gmail.com>
On Mon, Aug 27, 2018 at 01:35:09PM +0200, Ondrej Mosnacek wrote:
> On Fri, Aug 24, 2018 at 9:51 PM Richard Guy Briggs <rgb@redhat.com> wrote:
> > It appears this time_tai use of "constant" is different than
> > time_constant, the former not mentioned by Miroslav Lichvar. What is it
> > and is it important to log for security? It sounds like it is
> > important.
> The TAI offset is the offset of the clock from the International
> Atomic Time, so basically the time zone offset. I suppose it can't
> influence the audit timestamps, but changing timezones can still cause
> all sorts of confusion throughout the system, so intuitively I would
> say we should log it.
It's not related to timezones. ADJ_TAI sets the offset of the system
TAI clock (CLOCK_TAI) relative to the standard UTC clock
(CLOCK_REALTIME). CLOCK_TAI is rarely used by applications. Setting
the TAI offset effectively injects a whole-second offset to the TAI
time.
--
Miroslav Lichvar
next prev parent reply other threads:[~2018-08-27 11:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 11:59 [PATCH ghak10 v5 0/2] audit: Log modifying adjtimex(2) calls Ondrej Mosnacek
2018-08-24 12:00 ` [PATCH ghak10 v5 1/2] audit: Add functions to log time adjustments Ondrej Mosnacek
2018-08-24 18:33 ` John Stultz
2018-08-27 8:28 ` Ondrej Mosnacek
2018-09-13 15:54 ` Richard Guy Briggs
2018-09-17 12:33 ` Ondrej Mosnacek
2018-08-27 7:50 ` Miroslav Lichvar
2018-08-27 9:13 ` Ondrej Mosnacek
2018-08-27 16:38 ` Steve Grubb
2018-09-13 13:59 ` Ondrej Mosnacek
2018-09-13 15:14 ` Richard Guy Briggs
2018-09-17 12:32 ` Ondrej Mosnacek
2018-09-14 3:09 ` Paul Moore
2018-09-17 12:33 ` Ondrej Mosnacek
2018-09-14 3:18 ` Paul Moore
2018-09-14 15:16 ` Richard Guy Briggs
2018-09-14 15:34 ` Steve Grubb
2018-09-14 16:24 ` Richard Guy Briggs
2018-09-17 14:36 ` Paul Moore
2018-09-17 12:38 ` Ondrej Mosnacek
2018-09-17 14:20 ` Richard Guy Briggs
2018-09-17 14:50 ` Paul Moore
2018-09-21 11:21 ` Ondrej Mosnacek
2018-09-22 20:42 ` Paul Moore
2018-08-24 12:00 ` [PATCH ghak10 v5 2/2] timekeeping/ntp: Audit clock/NTP params adjustments Ondrej Mosnacek
2018-08-24 19:47 ` Richard Guy Briggs
2018-08-24 20:20 ` John Stultz
2018-08-27 11:35 ` Ondrej Mosnacek
2018-08-27 11:45 ` Miroslav Lichvar [this message]
2018-08-27 12:02 ` Ondrej Mosnacek
2018-08-27 21:42 ` Thomas Gleixner
2018-09-13 15:35 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827114557.GN27091@localhost \
--to=mlichvar@redhat.com \
--cc=john.stultz@linaro.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=rgb@redhat.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox