* [PATCH] ARM: at91: pm: remove pm_bu initialization in at91_pm_backup_init()
@ 2018-08-08 7:47 Claudiu Beznea
2018-08-27 15:10 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Claudiu Beznea @ 2018-08-08 7:47 UTC (permalink / raw)
To: nicolas.ferre, alexandre.belloni, linux
Cc: linux-arm-kernel, linux-kernel, Claudiu Beznea
There is no need to initialize pm_bu since it is used only if backup
mode is selected. In case backup mode initialization fails (which means
pm_bu is invalid) the ULP0 mode will be selected.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
arch/arm/mach-at91/pm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
index c8ef696b83b6..901d6445964d 100644
--- a/arch/arm/mach-at91/pm.c
+++ b/arch/arm/mach-at91/pm.c
@@ -577,8 +577,6 @@ static int __init at91_pm_backup_init(void)
if (!at91_is_pm_mode_active(AT91_PM_BACKUP))
return 0;
- pm_bu = NULL;
-
np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-sfrbu");
if (!np) {
pr_warn("%s: failed to find sfrbu!\n", __func__);
@@ -587,7 +585,6 @@ static int __init at91_pm_backup_init(void)
pm_data.sfrbu = of_iomap(np, 0);
of_node_put(np);
- pm_bu = NULL;
np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-securam");
if (!np)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: at91: pm: remove pm_bu initialization in at91_pm_backup_init()
2018-08-08 7:47 [PATCH] ARM: at91: pm: remove pm_bu initialization in at91_pm_backup_init() Claudiu Beznea
@ 2018-08-27 15:10 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2018-08-27 15:10 UTC (permalink / raw)
To: Claudiu Beznea; +Cc: nicolas.ferre, linux, linux-arm-kernel, linux-kernel
On 08/08/2018 10:47:40+0300, Claudiu Beznea wrote:
> There is no need to initialize pm_bu since it is used only if backup
> mode is selected. In case backup mode initialization fails (which means
> pm_bu is invalid) the ULP0 mode will be selected.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> arch/arm/mach-at91/pm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-27 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-08 7:47 [PATCH] ARM: at91: pm: remove pm_bu initialization in at91_pm_backup_init() Claudiu Beznea
2018-08-27 15:10 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox