From: Greg KH <gregkh@linuxfoundation.org>
To: Tom Todd <thomas.m.a.todd@gmail.com>
Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtlwifi: efuse: fixed a line length coding style issue
Date: Mon, 27 Aug 2018 19:51:08 +0200 [thread overview]
Message-ID: <20180827175108.GD27089@kroah.com> (raw)
In-Reply-To: <20180813211120.17015-1-thomas.m.a.todd@gmail.com>
On Mon, Aug 13, 2018 at 10:11:21PM +0100, Tom Todd wrote:
> Fixed a code style issue. Line length over 80 characters.
>
> Signed-off-by: Tom Todd <thomas.m.a.todd@gmail.com>
> ---
> drivers/staging/rtlwifi/efuse.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtlwifi/efuse.c b/drivers/staging/rtlwifi/efuse.c
> index 1dc71455f270..49ec9728fb04 100644
> --- a/drivers/staging/rtlwifi/efuse.c
> +++ b/drivers/staging/rtlwifi/efuse.c
> @@ -245,7 +245,8 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
> if (!efuse_word)
> goto out;
> for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) {
> - efuse_word[i] = kcalloc(efuse_max_section, sizeof(u16), GFP_ATOMIC);
> + efuse_word[i] =
> + kcalloc(efuse_max_section, sizeof(u16), GFP_ATOMIC);
No, keep the kcalloc on the same line and just wrap any needed
parameters.
thanks,
greg k-h
prev parent reply other threads:[~2018-08-27 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 21:11 [PATCH] Staging: rtlwifi: efuse: fixed a line length coding style issue Tom Todd
2018-08-27 17:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827175108.GD27089@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.m.a.todd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox